Skip to content

fix(ios): prevent app crash in Release builds #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomson-t merged 1 commit into from
Mar 5, 2026
Merged

fix(ios): prevent app crash in Release builds #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions ios/RNMParticle/RNMPRokt.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,17 @@ - (void)setMethodQueue:(dispatch_queue_t)methodQueue
}

#ifdef RCT_NEW_ARCH_ENABLED
// New Architecture Implementation
- (void)selectPlacements:(NSString *)identifer
attributes:(NSDictionary *)attributes
placeholders:(NSDictionary *)placeholders
roktConfig:(JS::NativeMPRokt::RoktConfigType &)roktConfig
fontFilesMap:(NSDictionary *)fontFilesMap
{
NSMutableDictionary *finalAttributes = [self convertToMutableDictionaryOfStrings:attributes];

// Convert JS struct to NSDictionary for internal use
// Extracts roktConfig fields into an NSDictionary, returning nil when the
// TurboModule bridge passes a null C++ reference for an omitted optional param.
// __attribute__((optnone)) is required: &ref != nullptr is UB in C++ and the
// compiler removes the check at -O2, causing a SIGSEGV in Release builds.
static NSDictionary * __attribute__((optnone)) safeExtractRoktConfigDict(
JS::NativeMPRokt::RoktConfigType &roktConfig) {
if (&roktConfig == nullptr) {
return nil;
}
NSMutableDictionary *roktConfigDict = [[NSMutableDictionary alloc] init];
if (&roktConfig != nullptr && roktConfig.cacheConfig().has_value()) {
if (roktConfig.cacheConfig().has_value()) {
NSMutableDictionary *cacheConfigDict = [[NSMutableDictionary alloc] init];
auto cacheConfig = roktConfig.cacheConfig().value();
if (cacheConfig.cacheDurationInSeconds().has_value()) {
Expand All @@ -80,7 +79,19 @@ - (void)selectPlacements:(NSString *)identifer
}
roktConfigDict[@"cacheConfig"] = cacheConfigDict;
}
return roktConfigDict;
}

// New Architecture Implementation
- (void)selectPlacements:(NSString *)identifer
attributes:(NSDictionary *)attributes
placeholders:(NSDictionary *)placeholders
roktConfig:(JS::NativeMPRokt::RoktConfigType &)roktConfig
fontFilesMap:(NSDictionary *)fontFilesMap
{
NSMutableDictionary *finalAttributes = [self convertToMutableDictionaryOfStrings:attributes];

NSDictionary *roktConfigDict = safeExtractRoktConfigDict(roktConfig);
MPRoktConfig *config = [self buildRoktConfigFromDict:roktConfigDict];
#else
// Old Architecture Implementation
Expand Down
Loading