Skip to content

ci: add trunk#285

Merged
jamesnrokt merged 5 commits intomainfrom
ci/add-trunk-check
Mar 5, 2026
Merged

ci: add trunk#285
jamesnrokt merged 5 commits intomainfrom
ci/add-trunk-check

Conversation

@jamesnrokt
Copy link
Contributor

Background

  • This repo had no static analysis or formatting enforcement. Adding Trunk aligns it with other ROKT SDKs (sdk-android-source, sdk-ios-source, rokt-ux-helper-*).

What Has Changed

  • Added .trunk/trunk.yaml with 15 linters, a custom mparticle-api-key-check rule to detect committed API keys, path/linter ignores, and git hook actions
  • Added trunk-check as the first required job in the pull request workflow (blocks pr-notify)
  • Added .github/workflows/trunk-upgrade.yml to auto-upgrade linter versions on the 1st of each month

Screenshots/Video

  • N/A

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • yamllint is disabled (matches sdk-android-source)
  • CHANGELOG.md is excluded from markdownlint as its format intentionally violates MD001/MD024/MD025
  • Example/Pods, Example/Podfile.lock, RNExample/Gemfile* are excluded from all linters

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • N/A

jamesnrokt and others added 3 commits March 5, 2026 11:39
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jamesnrokt jamesnrokt requested a review from a team as a code owner March 5, 2026 16:43
Copilot AI review requested due to automatic review settings March 5, 2026 16:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jamesnrokt jamesnrokt merged commit 1f88907 into main Mar 5, 2026
10 checks passed
@jamesnrokt jamesnrokt deleted the ci/add-trunk-check branch March 5, 2026 18:42
@rokt-releases rokt-releases bot mentioned this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants