feat: add Rokt select placement and refactor sample app, sdk to support new react native version#216
Conversation
chore: Update project structure and add new features - Added new development scripts and configuration files. - Introduced new Android and iOS modules for Rokt integration. - Updated Gradle and Xcode project settings. - Removed deprecated files and adjusted sample project structure. - Enhanced TypeScript definitions and added new components for better integration.
f14a74a to
6d54154
Compare
BrandonStalnaker
left a comment
There was a problem hiding this comment.
LG from the iOS side
- Use eslint and replace standard - Fix the lint errors
rmi22186
left a comment
There was a problem hiding this comment.
i wasn't able to comment in line for some reason, so I'll point to it:
sample/index.js line 180 when you are creating the config using a builder pattern, my comment was:
What do you think about instead of making this a buidler pattern, which isn't done elsewhere in the React code and is very Android-y, that we can either use a factor method, which is more idiomatic, or constructor which isnt idiomatic, but how we have been doing most of the API. https://docs.mparticle.com/developers/client-sdks/react-native/getting-started/#events
ie:
1.
const config = MParticle.Rokt.createRoktConfig("dark", createCacheConfig(3600));
or
2.
const cacheConfig = new CacheConfig(3600, { userId: "123" });
const config = new RoktConfigClass("dark", cacheConfig);
2 seems to match most of the other API, although I prefer 1 and 1 is more idiomatic per cursor
Removed builder and added static create methods
Thanks @rmi22186 I've refactored the code. |
- Updated `getSession` to return a string instead of SessionInfo. - Made `attributes` a required parameter in the Rokt class method. - Removed unused RoktConfigBuilder from exports and sample app.
Summary
Testing Plan
{explain how this has been tested, and what additional testing should be done}
Master Issue
Closes https://go.mparticle.com/work/SQDSDKS-7455