Skip to content

feat: add Rokt select placement and refactor sample app, sdk to support new react native version#216

Merged
thomson-t merged 7 commits intodevelopmentfrom
feat/SQDSDKS-7455-rokt-sdk-select-api
Jul 18, 2025
Merged

feat: add Rokt select placement and refactor sample app, sdk to support new react native version#216
thomson-t merged 7 commits intodevelopmentfrom
feat/SQDSDKS-7455-rokt-sdk-select-api

Conversation

@thomson-t
Copy link
Contributor

Summary

  • chore: Update project structure and add new features
  • Added new development scripts and configuration files.
  • Introduced new Android and iOS modules for Rokt integration.
  • Updated Gradle and Xcode project settings.
  • Removed deprecated files and adjusted sample project structure.
  • Enhanced TypeScript definitions and added new components for better integration.

Testing Plan

{explain how this has been tested, and what additional testing should be done}

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-7455

chore: Update project structure and add new features
- Added new development scripts and configuration files.
- Introduced new Android and iOS modules for Rokt integration.
- Updated Gradle and Xcode project settings.
- Removed deprecated files and adjusted sample project structure.
- Enhanced TypeScript definitions and added new components for better integration.
@thomson-t thomson-t force-pushed the feat/SQDSDKS-7455-rokt-sdk-select-api branch from f14a74a to 6d54154 Compare July 11, 2025 06:12
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from the iOS side

- Use eslint and replace standard
- Fix the lint errors
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasn't able to comment in line for some reason, so I'll point to it:

sample/index.js line 180 when you are creating the config using a builder pattern, my comment was:

What do you think about instead of making this a buidler pattern, which isn't done elsewhere in the React code and is very Android-y, that we can either use a factor method, which is more idiomatic, or constructor which isnt idiomatic, but how we have been doing most of the API. https://docs.mparticle.com/developers/client-sdks/react-native/getting-started/#events

ie:
1.

const config = MParticle.Rokt.createRoktConfig("dark", createCacheConfig(3600));

or
2.

const cacheConfig = new CacheConfig(3600, { userId: "123" });
const config = new RoktConfigClass("dark", cacheConfig);

2 seems to match most of the other API, although I prefer 1 and 1 is more idiomatic per cursor

Removed builder and added static create methods
@thomson-t
Copy link
Contributor Author

2 seems to match most of the other API, although I prefer 1 and 1 is more idiomatic per cursor

Thanks @rmi22186 I've refactored the code.

- Updated `getSession` to return a string instead of SessionInfo.
- Made `attributes` a required parameter in the Rokt class method.
- Removed unused RoktConfigBuilder from exports and sample app.
@thomson-t thomson-t merged commit a4f9322 into development Jul 18, 2025
10 checks passed
@thomson-t thomson-t deleted the feat/SQDSDKS-7455-rokt-sdk-select-api branch July 18, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants