-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Block mp cookies when noFunctional is true #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khushi1033
wants to merge
26
commits into
development
Choose a base branch
from
feat/SDKE-972-block-cookies-based-on-rokt-privacy-flags
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e74dedb
block mp cookies when nofunctional is true
khushi1033 add2e74
clean up comments
khushi1033 6e5f562
addressed pr comments
khushi1033 9f9d3c0
Update src/identity-utils.ts
khushi1033 892cc5a
use disabled vault
khushi1033 c73bb71
disable cookie sync when nofunctional is true
khushi1033 e67fb76
changes from comments
khushi1033 adb5938
added additional tests
khushi1033 d8564ce
verify events still sent without identity when noFuntional
khushi1033 0086eb2
testing of all forwarder methods
khushi1033 17796db
tests for when no identity provided
khushi1033 431937b
test mparticle intialized and logevent
khushi1033 fd9ab0f
chore: add codeowners (#1193)
nickolas-dimitrakas 5bcbecb
Merge branch 'master' into feat/SDKE-972-block-cookies-based-on-rokt-…
khushi1033 a2fbf2c
added flag so events not sent to forwarders twice
khushi1033 e41b195
clean up whitespaces
khushi1033 560b2c5
Merge branch 'development' into feat/SDKE-972-block-cookies-based-on-…
khushi1033 9359ac0
add additional tests for event forwarding behavior
khushi1033 7373c3a
Merge branch 'feat/SDKE-972-block-cookies-based-on-rokt-privacy-flags…
khushi1033 3f9bfd8
make seperate function for event sending under noFunctional
khushi1033 3ce0e1d
cleanup based on code anlysis suggestions
khushi1033 0d7ad3c
Apply suggestions from code review
khushi1033 6c930f8
remove isSystemEvent check
khushi1033 f9382d1
added comments to test for context on events queued
khushi1033 db5b930
Apply suggestion from @rmi22186
khushi1033 fd99966
Update src/apiClient.ts
khushi1033 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * @mParticle/sdk-team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.