Skip to content

ci: update node and actions version#788

Merged
jaissica12 merged 14 commits intomasterfrom
ci/SDKE-684-upgrade-ci-node-and-actions
Dec 16, 2025
Merged

ci: update node and actions version#788
jaissica12 merged 14 commits intomasterfrom
ci/SDKE-684-upgrade-ci-node-and-actions

Conversation

@jaissica12
Copy link
Copy Markdown
Contributor

@jaissica12 jaissica12 commented Dec 8, 2025

Background

  • Local/CI installs and TypeDoc builds were failing due to a legacy git‑based TypeDoc theme that pulled node-sass@4.x (requires Python 2) and an older typedoc@0.20.x that only supports TypeScript ≤4.2.
  • Type checking on TS ≥5 and modern Node types caused issues (ESNext.Disposable, Buffer iterator types).
  • @types/sinon conflicted with Sinon’s built‑in types
  • GitHub Actions referenced deprecated actions/Node versions, leading to EBADENGINE warnings on Node 18 and occasional artifact name collisions.
  • BaseEvent#toEventAPIObject was an abstract property with a default initializer, which is invalid in TypeScript 5.

What Has Changed

  • src/events.ts

    • Convert abstract toEventAPIObject = (): void => {} to abstract toEventAPIObject(): EventAPIObject; for TS 5 compatibility.
  • typedoc.json

    • Removed deprecated "mode": "file".
    • Dropped custom typedoc-default-themes line (now uses TypeDoc’s default theme).
  • package.json

    • Tooling: typedoc → ^0.28.15, typescript → ^5.9.3, @types/node → ^20.
    • Semantic‑release plugins bumped up
    • Removed legacy typedoc-default-themes (removes node-sass postinstall).
    • Added @sinonjs/fake-timers@^8 for stable timer tests
  • .github/workflows/pull-request.yml

    • Migrated to actions/checkout@v4, actions/setup-node@v4.
    • PR matrix: node-version: [20.x, 22.x, 24.x] (removes Node 18 from CI).
    • artifact upload name made unique to avoid (409) Conflict: npm-logs-${{ github.job }}-${{ matrix.node-version || 'latest' }}-run${{ github.run_attempt }}.
  • .github/workflows/release.yml

    • Uses actions/*@v4, node-version: 24.x.
  • .github/dependabot.yml

    • Add global ignore for @types/sinon to prevent reintroduction and noisy version bumps (Sinon includes its own types).

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 marked this pull request as ready for review December 11, 2025 20:51
@jaissica12 jaissica12 requested a review from rmi22186 December 15, 2025 21:59
@rmi22186
Copy link
Copy Markdown
Member

@jaissica12 - should be merged to master first since it's ci/cd

@jaissica12 jaissica12 changed the base branch from development to master December 16, 2025 20:44
@jaissica12 jaissica12 merged commit 13963bb into master Dec 16, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants