Skip to content

feat: remove no location product#32

Open
nickolas-dimitrakas wants to merge 2 commits intomainfrom
feat/remove-nolocation-product
Open

feat: remove no location product#32
nickolas-dimitrakas wants to merge 2 commits intomainfrom
feat/remove-nolocation-product

Conversation

@nickolas-dimitrakas
Copy link
Collaborator

@nickolas-dimitrakas nickolas-dimitrakas commented Feb 26, 2026

Background

  • The core mParticle Apple SDK (workstation/9.0-Release) has removed the NoLocation product and raised the minimum deployment target to iOS/tvOS 15.0. The media SDK needs to be aligned with these changes.

What Has Changed

  • Removed the mParticle-Apple-Media-SDK-NoLocation SPM product, target, and symlink
  • Removed the mParticleMediaNoLocation CocoaPods subspec
  • Removed the NoLocation Xcode target, test target, and shared scheme
  • Removed #if canImport conditional imports for NoLocation in source and tests
  • Updated minimum deployment targets from iOS/tvOS 12.0 to 15.0
  • Updated core SDK dependency to point to workstation/9.0-Release branch
  • Updated swift-tools-version from 5.3 to 5.9
  • Removed NoLocation build and test steps from CI workflows
  • Cleaned up README to remove NoLocation documentation

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Once 9.0.0 is tagged, update Package.swift and xcodeproj to use a version-based dependency instead of the branch reference and can merge to main.
  • Adjusted main branch protection ruleset to remove the NoLocation test suite as a requirement.

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • Closes NO-JIRA

Copy link
Contributor

@jamesnrokt jamesnrokt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickolas-dimitrakas - Given this is a breaking change should we workstation it or is this the only change we're making on this side of things?

@nickolas-dimitrakas
Copy link
Collaborator Author

nickolas-dimitrakas commented Mar 4, 2026

@nickolas-dimitrakas - Given this is a breaking change should we workstation it or is this the only change we're making on this side of things?

@jamesnrokt Should be the only changes. Also not finalized yet, still need to make adjustments.

Copy link
Contributor

@jamesnrokt jamesnrokt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the wait to merge tag pending the release of the core SDK v9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants