Skip to content

refactor: Re-organize class hierarchy #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cbowie-mp wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

refactor: Re-organize class hierarchy #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
466511d
Add types to operator names
cbowie-mp Jun 19, 2025
fefb097
Change a lot of things
cbowie-mp Jun 19, 2025
b3af7bf
Fix imports
cbowie-mp Jun 19, 2025
1a488a8
Add titles to everything
cbowie-mp Jun 19, 2025
34b14bc
Update JSON schema + fix audience titles
cbowie-mp Jun 19, 2025
d4f8c34
Update models and fix tests
cbowie-mp Jun 19, 2025
1b6ad5a
Fix python SDK gen
cbowie-mp Jun 19, 2025
00bcb7f
Delete unused SDK
cbowie-mp Jun 20, 2025
1e33486
Merge branch 'main' into refactor/re-organize-hierarchy
cbowie-mp Jun 30, 2025
9bf7f7b
Update with audience changes
cbowie-mp Jun 30, 2025
319cf39
Update version
cbowie-mp Jun 30, 2025
d4fb5a9
Add back expressions
cbowie-mp Jun 30, 2025
2bd7854
Add type fixing script + fix union types
cbowie-mp Jun 30, 2025
a14e27a
Change how expression is defined
cbowie-mp Jul 1, 2025
bffff87
Use classes + interfaces
cbowie-mp Jul 1, 2025
f92ad20
More changes
cbowie-mp Jul 1, 2025
93af3f4
Fix operator
cbowie-mp Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PYTHON_OUTPUT_DIR := sdk/python/mp_audience_sdk/models
SCHEMA_FILE := schema/audience-definition-schema.json
PYTHON_OUTPUT_FILE := $(PYTHON_OUTPUT_DIR)/audience_models.py
TYPESCRIPT_SCHEMA_DIR := sdk/typescript-schema
PYTHON_FIX_TYPE_FILE := sdk/python/fixup_types.py

build: build-typescript generate-python-models test

Expand All @@ -23,7 +24,9 @@ generate-python-models:
--output-model-type pydantic_v2.BaseModel \
--field-constraints \
--snake-case-field \
--encoding utf-8
--encoding utf-8 \
--use-union-operator
python $(PYTHON_FIX_TYPE_FILE) $(PYTHON_OUTPUT_FILE)
black $(PYTHON_OUTPUT_DIR)

test:
Expand Down
Loading
Loading