Conversation
Made-with: Cursor
|
| @@ -0,0 +1,336 @@ | |||
| { | |||
There was a problem hiding this comment.
Few thoughts. This is hardcoded, which means AI or human should be aware of this and it a new component is added (not a case for core components, but will be for custom ones) - they will need to update this file. Second, let’s drop variants. I really don’t know if it’s meaningful for consumers. I think what treated as variants here are all properties that component has. But we don’t use a lot of them. And in some cases we even want to prevent usage of some. Think of a buttons. We have type, we have size, we have shape. This is straightforward. But we also have ghost true or false, icon, onClick function. It will count it all. That’s why button has 39 variants. It will be more confusing. So I vote for getting rid of it for now.
| ] | ||
| }, | ||
| { | ||
| "name": "Layout", |
There was a problem hiding this comment.
Let’s exclude layout from here
| ] | ||
| }, | ||
| { | ||
| "name": "Other", |
There was a problem hiding this comment.
Other and not prod ready are also not needed here
| return `${window.top.location.origin}/aquarium/` | ||
| } | ||
| return `${window.top.location.origin}/` | ||
| } |
There was a problem hiding this comment.
Note to self: review this
| } | ||
|
|
||
| const previewContainerStyle = { | ||
| background: '#F5F5F5', |
There was a problem hiding this comment.
Ugh. We should try to use design tokens instead of hardcoded values
| } | ||
|
|
||
| return ( | ||
| <a |
There was a problem hiding this comment.
We not using card component?
| Simple, flexible, and reliable—this library helps you focus on building great experiences without | ||
| worrying about the basics. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
Ugh. I updated Claude to not use raw html and prefer our components. But cursor is not aware 😭
2 participants
Redesigns the introduction page with dynamic component cards pulled from componentCategories.json, grouped by category, with click-through navigation to each component's documentation page.