Skip to content
This repository was archived by the owner on Jul 29, 2025. It is now read-only.

Conversation

@estshorter
Copy link
Contributor

@estshorter estshorter commented Feb 3, 2021

Changelog

Added

  • Add getDateTime() and setDateTime()
  • Getters and setters accept a reference as a parameter for consistency

Changed

  • New member variable _wire which is a reference to a TwoWire instance. Users can select which instance to use (Wire or Wire1). Default: Wire (no change)
  • begin() accepts parameters for TwoWire::begin() to give users flexiblity.

Removed

  • Remove magic numbers (registers and masks) by using struct and enum
  • Remove getTime(void)
  • Remove redundant casts

Fixed

Note

No API breakage except for removing getTime(void).
I believe this is not an issue because this function only sets a private member variable trdata to data from BM8563, and trdata is not used in the other functions.

@TinyuZhao TinyuZhao force-pushed the main branch 3 times, most recently from 43c009f to 5144bf5 Compare July 17, 2023 06:31
@Gitshaoxiang Gitshaoxiang force-pushed the main branch 2 times, most recently from 062c2ac to 96180c4 Compare July 27, 2023 09:43
@Gitshaoxiang Gitshaoxiang force-pushed the main branch 2 times, most recently from 7bc1564 to 0e01781 Compare August 9, 2023 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant