Fix undefined reference to PHYS_TO_VIRT in acpi.c#26
Merged
m4rcel-lol merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
Co-authored-by: m4rcel-lol <187956479+m4rcel-lol@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add PHYS_TO_VIRT macro definition and include in acpi.c
Fix undefined reference to PHYS_TO_VIRT in acpi.c
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHYS_TO_VIRTis defined as a macro inkernel/include/mm.hbutdrivers/acpi/acpi.cnever included it, causing three undefined-reference linker errors.Changes
kernel/drivers/acpi/acpi.c: Add missing#include "../../include/mm.h"so thePHYS_TO_VIRTmacro is visible at compile time.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.