fix: clear result fields on re-run to avoid stale values (#197) - #226
Open
Aaradhya-07 wants to merge 1 commit into
Open
fix: clear result fields on re-run to avoid stale values (#197)#226Aaradhya-07 wants to merge 1 commit into
Aaradhya-07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startTest()reset the internal JS state (this.measurementResult) but nevercleared the result fields in the DOM. If a re-run failed partway (e.g. ndt7's
download phase succeeded but upload threw), the failed field kept showing the
previous run's value.
This adds a
clearResults()helper that blankss2cRate,c2sRate,latency,and
lossat the start of each run, back to their initial empty state.fixes #197
This change is