m-blaha · m-blaha · Jun 27, 2025 · Jun 30, 2025 · Jul 1, 2025 · Jul 2, 2025
diff --git a/.github/workflows/weblate-sync-pot.yml b/.github/workflows/weblate-sync-pot.yml
@@ -16,6 +16,15 @@ jobs:
       options: --user root
     timeout-minutes: 10
     steps:
+      - uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ vars.RSM_CI_APP_ID }}
+          private-key: ${{ secrets.RSM_CI_APP_PRIVATE_KEY }}
+          permissions:
+            contents: "write"
+          repositories: "rpm-software-management/dnf5-l10n"
+
       - name: Clone source repository
         uses: actions/checkout@v4
         with:
@@ -33,7 +42,7 @@ jobs:
         with:
           path: l10n
           repository: ${{ github.repository }}-l10n
-          ssh-key: ${{ secrets.L10N_SSH_KEY }}
+          token: ${{ steps.app-token.outputs.token }}
 
       - name: Commit .pot to weblate repo
         run: |

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,70 @@
+# 5.2.16.0
+
+- Update translations from weblate
+- Bump minor version to 5.2.16
+- dnfdaemon: Enable download-only transaction execution
+- dnfdaemon: Make it possible to set 'interactive' option for Rpm::system_upgrade()
+- dnfdaemon: Make it possible to set 'interactive' option for Offline::cancel(), Offline::clean(), Offline::set_finish_action()
+- dnfdaemon: Make it possible to set 'interactive' option for Repo::confirm_key(), Repo::enable(), Repo::disable()
+- dnfdaemon: Make it possible to set 'interactive' option for Goal::do_transaction()
+- dnfdaemon: Make it possible to set 'interactive' option for Base::clean()
+- test: Add test for temp files toml with missing key
+- repo: Do not fail on empty temporary files toml
+- actions: Replace L10N_SSH_KEY secret with RSM CI GitHub token
+- dnf5: Support --installed-from-repo= for "do"
+- Disable fastest_mirror callback for package downloading
+- Copy return value from `SetConstIterator::operator*`
+- tests: verify `SetConstIterator` works in Python bindings
+- test_nevra.py: change formatting to satisfy autopep8
+- Fix various typos found by Lintian
+- tests: fix compat with dash and other shellcheck warnings
+- dnf5: Support --installed-from-repo= for swap
+- dnf5: Support --installed-from-repo= for upgrade/downgrade/distro-sync
+- Goal: add_rpm_(upgrade/distro_sync) Improve support from_repo_ids
+- Goal: Honor set_from_repo_ids in add_up_down_distrosync_to_goal
+- dnf5: Support --installed-from-repo= for reinstall/remove
+- Goal: Honor set_from_repo_ids in add_(remove,reinstall)_to_goal
+- dnf5: Support --installed-from-repo= for repoquery/list/info
+- rpm::PackageQuery: New filter "filter_from_repo_id"
+- dnf5: "--from-repo=" option enables and validates source repositories
+- Goal::Impl::add_install_to_goal: Fix to_repo_ids handling
+- dnf5: upgrade/distro-sync: Apply --from-repo only if pkgs are specified
+- Goal::Impl::add_specs_to_goal: Skip processing of empty query in *ALL*
+- Goal::Impl::add_specs_to_goal: Apply to_repo_ids settings in *ALL*
+- Add unit tests for nevra parsing
+- swig: Add bindings for templated functions that convert nevra to string
+
+# 5.2.15.0
+
+- Update translations from weblate
+- Adapt missing gpg key check for parallel downloading
+- repoclosure: skip rich dependencies
+- search: Do not separate a package from a summary with a colon
+- Fix: add_up_down_distrosync_to_goal: to_repo_ids filtering
+- dnf5: distro-sync: Argument "--from-repo"
+- swig: Add %thread directive for repo_sack.hpp for Python
+- dnfdaemon: Fix a crash under dnf5daemon::DownloadCB::create_signal_download()
+- Add dnf5daemon-server requirement for polkit subpkg
+- doc: Correct handling the translations
+- dnfdaemon-client: Call server methods asynchronously
+- offline: Require D-Bus socket service from dnf5-offline-transaction.service
+- offline: Perform gracefull powerof/reboot instead of immediate one
+- readthedocs: add swig include to fix doc builds
+- readthedocs: extract `SOURCE_DIR` variable
+- readthedocs: fix path joining
+- dnfdaemon: Make permission check more consistent
+- dnfdaemon: Removed incorrect output parameter names
+- dnfdaemon: support all_advisories option for recent_changes()
+- advisory: Add support for filtering advisories by Nevra
+- dnfdaemon: support installonly pkgs in recent_changes()
+- dnfdaemon: Add new History interface
+- dnf5: repoclosure: Support globs in "--check=" option
+- doc: Handling translations
+- Docs: enhance install command behavior description
+- Unify commands help with package specs
+- Introduce new format denoting package spec formats
+- test: ease path assertions in tests
+
 # 5.2.14.0
 
 - Update translations from weblate
@@ -800,7 +867,7 @@
 - dnfdaemon: Missing signal registration
 - doc: config manager plugin: wrap too long lines
 - doc: document config-manager plugin
-- Packit: get version from specfile for copr_builds againts main
+- Packit: get version from specfile for copr_builds against main
 - Update tests to use new `load_repos()` API
 - Use new load_repos instead of deprecated update_and_load_enabled_repos
 - Make `libdnf5::repo::Repo::load()` private

diff --git a/README.md b/README.md
@@ -106,15 +106,19 @@ For details about building and testing DNF5, see the [Development environment se
 Translating
 -----------
 
-Translating DNF5 from English to other langauges happens at
+Translating DNF5 from English to other languages happens at
 [Fedora Weblate](https://translate.fedoraproject.org/projects/dnf5/)
 translation web site.
 
-The web site extracts new English messages from this repository. Users of the web
-site translate them there and the web site exports the finshed translations to
+A [GitHub workflow](.github/workflows/weblate-sync-pot.yml) extracts new English
+messages from this repository every day and commits them to
 [dnf5-l10n](https://github.com/rpm-software-management/dnf5-l10n) repository.
-The translation catalogs from the repository are copied into a DNF5 release
-tar ball on every DNF5 release.
+The translation web site then presents them to its users who translate
+them there and the web site saves the finished translations back to the
+dnf5-l10n repository.
+Finally, the translation catalogs from that repository are
+[copied](.github/actions/weblate-pull-translations/action.yml) into this repository
+just before [every DNF5 release](.github/workflows/prepare-release.yml).
 
 
 License

diff --git a/VERSION.cmake b/VERSION.cmake
@@ -1,6 +1,6 @@
 set(DEFAULT_PROJECT_VERSION_PRIME 5)
 set(DEFAULT_PROJECT_VERSION_MAJOR 2)
-set(DEFAULT_PROJECT_VERSION_MINOR 14)
+set(DEFAULT_PROJECT_VERSION_MINOR 16)
 set(DEFAULT_PROJECT_VERSION_MICRO 0)
 
 if(DEFINED PROJECT_VERSION_PRIME)

diff --git a/bindings/libdnf5/common.i b/bindings/libdnf5/common.i
@@ -225,6 +225,12 @@ fix_swigtype_trait(ClassName)
 %ignore libdnf5::SetConstIterator::operator++(int);
 %ignore libdnf5::SetConstIterator::operator--(int);
 %ignore libdnf5::SetConstIterator::operator->() const;
+
+%typemap(out, noblock=1) copy_return_value {
+    // create a copy that is owned by the caller
+    $result = SWIG_NewPointerObj((new $*1_ltype(*$1)), $1_descriptor, 1);
+}
+
 %include "libdnf5/common/set.hpp"
 #if defined(SWIGPYTHON)
 %extend libdnf5::Set {

diff --git a/bindings/libdnf5/comps.i b/bindings/libdnf5/comps.i
@@ -41,13 +41,15 @@
 %include "libdnf5/comps/group/package.hpp"
 %include "libdnf5/comps/group/group.hpp"
 %template(VectorPackage) std::vector<libdnf5::comps::Package>;
+%typemap(out) libdnf5::comps::Group & libdnf5::SetConstIterator<libdnf5::comps::Group>::operator* = copy_return_value;
 %template(SetConstIteratorGroup) libdnf5::SetConstIterator<libdnf5::comps::Group>;
 %template(SetGroup) libdnf5::Set<libdnf5::comps::Group>;
 %template(SackQueryGroup) libdnf5::sack::Query<libdnf5::comps::Group>;
 %include "libdnf5/comps/group/query.hpp"
 add_iterator(SetGroup)
 
 %include "libdnf5/comps/environment/environment.hpp"
+%typemap(out) libdnf5::comps::Environment & libdnf5::SetConstIterator<libdnf5::comps::Environment>::operator* = copy_return_value;
 %template(SetConstIteratorEnvironment) libdnf5::SetConstIterator<libdnf5::comps::Environment>;
 %template(SetEnvironment) libdnf5::Set<libdnf5::comps::Environment>;
 %template(SackQueryEnvironment) libdnf5::sack::Query<libdnf5::comps::Environment>;

diff --git a/bindings/libdnf5/repo.i b/bindings/libdnf5/repo.i
@@ -1,5 +1,6 @@
 #if defined(SWIGPYTHON)
-%module(package="libdnf5", directors="1") repo
+%module("threads"=1, package="libdnf5", directors="1") repo
+%nothread;
 #elif defined(SWIGPERL)
 %module "libdnf5::repo"
 #elif defined(SWIGRUBY)
@@ -143,6 +144,7 @@ wrap_unique_ptr(DownloadCallbacksUniquePtr, libdnf5::repo::DownloadCallbacks);
 
 %include "libdnf5/repo/repo_weak.hpp"
 %template(RepoWeakPtr) libdnf5::WeakPtr<libdnf5::repo::Repo, false>;
+%typemap(out) libdnf5::WeakPtr<libdnf5::repo::Repo, false> & libdnf5::SetConstIterator<libdnf5::repo::RepoWeakPtr>::operator* = copy_return_value;
 %template(SetConstIteratorRepoWeakPtr) libdnf5::SetConstIterator<libdnf5::repo::RepoWeakPtr>;
 %template(SetRepoWeakPtr) libdnf5::Set<libdnf5::repo::RepoWeakPtr>;
 %template(SackQueryRepoWeakPtr) libdnf5::sack::Query<libdnf5::repo::RepoWeakPtr>;
@@ -153,6 +155,10 @@ wrap_unique_ptr(RepoCallbacksUniquePtr, libdnf5::repo::RepoCallbacks);
 
 %include "libdnf5/repo/repo_query.hpp"
 %template(SackRepoRepoQuery) libdnf5::sack::Sack<libdnf5::repo::Repo>;
+
+#if defined(SWIGPYTHON)
+%thread;
+#endif
 %include "libdnf5/repo/repo_sack.hpp"
 %template(RepoSackWeakPtr) libdnf5::WeakPtr<libdnf5::repo::RepoSack, false>;
 

diff --git a/bindings/libdnf5/rpm.i b/bindings/libdnf5/rpm.i
@@ -62,6 +62,8 @@
 %template(VectorNevraForm) std::vector<libdnf5::rpm::Nevra::Form>;
 %template(PairBoolNevra) std::pair<bool, libdnf5::rpm::Nevra>;
 %template(cmp_nevra) libdnf5::rpm::cmp_nevra<libdnf5::rpm::Nevra>;
+%template(to_full_nevra_string) libdnf5::rpm::to_full_nevra_string<libdnf5::rpm::Nevra>;
+%template(to_nevra_string) libdnf5::rpm::to_nevra_string<libdnf5::rpm::Nevra>;
 
 %include "libdnf5/rpm/versionlock_config.hpp"
 

diff --git a/common/utils/url.cpp b/common/utils/url.cpp
@@ -20,6 +20,10 @@ along with libdnf.  If not, see <https://www.gnu.org/licenses/>.
 
 #include "url.hpp"
 
+#include "string.hpp"
+
+#include <cctype>
+#include <vector>
 
 namespace libdnf5::utils::url {
 
@@ -34,4 +38,78 @@ bool is_url(std::string path) {
            path.starts_with("https://");
 }
 
+std::string url_encode(const std::string & src) {
+    auto no_encode = [](char ch) {
+        return (ch >= '0' && ch <= '9') || (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z') || ch == '-' ||
+               ch == '.' || ch == '_' || ch == '~';
+    };
+
+    // compute length of encoded string
+    auto len = src.length();
+    for (auto ch : src) {
+        if (!no_encode(ch)) {
+            len += 2;
+        }
+    }
+
+    // encode the input string
+    std::string encoded;
+    encoded.reserve(len);
+    for (auto ch : src) {
+        if (no_encode(ch)) {
+            encoded.push_back(ch);
+        } else {
+            encoded.push_back('%');
+            int hex;
+            hex = static_cast<unsigned char>(ch) >> 4;
+            hex += hex <= 9 ? '0' : 'a' - 10;
+            encoded.push_back(static_cast<char>(hex));
+            hex = static_cast<unsigned char>(ch) & 0x0F;
+            hex += hex <= 9 ? '0' : 'a' - 10;
+            encoded.push_back(static_cast<char>(hex));
+        }
+    }
+
+    return encoded;
+}
+
+std::string url_decode(const std::string & src) {
+    std::string decoded;
+    decoded.reserve(src.length());
+    auto hex_to_int = [](char ch) -> int {
+        if (ch >= '0' && ch <= '9') {
+            // digit
+            return ch - '0';
+        } else if (ch >= 'a' && ch <= 'f') {
+            // lowercase hex digit
+            return ch - 'a' + 10;
+        } else {
+            // uppercase hex digit (rely on std::isxdigit was performed before)
+            return ch - 'A' + 10;
+        }
+    };
+    for (std::size_t i = 0; i < src.length(); ++i) {
+        char ch = src[i];
+        if (ch == '%' && i + 2 < src.length() && std::isxdigit(src[i + 1]) && std::isxdigit(src[i + 2])) {
+            int byte_value = hex_to_int(src[i + 1]) * 16 + hex_to_int(src[i + 2]);
+            decoded.push_back(static_cast<char>(byte_value));
+            i += 2;
+        } else {
+            decoded.push_back(ch);
+        }
+    }
+    return decoded;
+}
+
+std::string url_path_encode(const std::string & url, bool preserve_already_encoded) {
+    // split by path separator and encode each part separately
+    std::vector<std::string> encoded_parts;
+    for (const auto & part : libdnf5::utils::string::split(url, "/")) {
+        // If preserve_already_encoded is true, decode first to prevent double-encoding (normalize)
+        encoded_parts.push_back(url_encode(preserve_already_encoded ? url_decode(part) : part));
+    }
+
+    return libdnf5::utils::string::join(encoded_parts, "/");
+}
+
 }  // namespace libdnf5::utils::url
diff --git a/common/utils/url.hpp b/common/utils/url.hpp
@@ -27,6 +27,24 @@ namespace libdnf5::utils::url {
 
 bool is_url(std::string path);
 
+/// Converts the given input string to a URL encoded string
+/// All input characters that are not a-z, A-Z, 0-9, '-', '.', '_' or '~' are converted
+/// to their "URL escaped" version (%NN where NN is a two-digit hexadecimal number).
+/// @param src String to encode
+/// @return URL encoded string
+std::string url_encode(const std::string & src);
+
+/// Convert the given URL encoded string to a decoded string.
+/// @param src String to decode
+/// @return URL decoded string
+std::string url_decode(const std::string & src);
+
+/// Encode the given string to be safe for use in a URL path. It preserves path separators.
+/// @param url The URL to encode.
+/// @param preserve_already_encoded If true, do not re-encode already encoded characters (e.g. the path was already encoded by createrepo_c)
+/// @return The encoded URL.
+std::string url_path_encode(const std::string & url, bool preserve_already_encoded);
+
 }  // namespace libdnf5::utils::url
 
 #endif  // LIBDNF5_UTILS_URL_HPP
diff --git a/dnf5-plugins/automatic_plugin/po/dnf5-plugin-automatic.pot b/dnf5-plugins/automatic_plugin/po/dnf5-plugin-automatic.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"

diff --git a/dnf5-plugins/builddep_plugin/po/ca.po b/dnf5-plugins/builddep_plugin/po/ca.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2025-02-24 18:43+0000\n"
 "Last-Translator: Joan Aymà <joan@ayma.cat>\n"
 "Language-Team: Catalan <https://translate.fedoraproject.org/projects/dnf5/"

diff --git a/dnf5-plugins/builddep_plugin/po/cs.po b/dnf5-plugins/builddep_plugin/po/cs.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2024-02-02 12:15+0000\n"
 "Last-Translator: Petr Ptacek <petr106@atlas.cz>\n"
 "Language-Team: Czech <https://translate.fedoraproject.org/projects/dnf5/dnf5-"

diff --git a/dnf5-plugins/builddep_plugin/po/de.po b/dnf5-plugins/builddep_plugin/po/de.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2024-05-14 01:26+0000\n"
 "Last-Translator: Dennis Koerner <dennis@bumblebeeman.dev>\n"
 "Language-Team: German <https://translate.fedoraproject.org/projects/dnf5/"

diff --git a/dnf5-plugins/builddep_plugin/po/dnf5-plugin-builddep.pot b/dnf5-plugins/builddep_plugin/po/dnf5-plugin-builddep.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"

diff --git a/dnf5-plugins/builddep_plugin/po/es.po b/dnf5-plugins/builddep_plugin/po/es.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2025-05-11 03:58+0000\n"
 "Last-Translator: gossypium <gossypium@users.noreply.translate.fedoraproject."
 "org>\n"

diff --git a/dnf5-plugins/builddep_plugin/po/fi.po b/dnf5-plugins/builddep_plugin/po/fi.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2024-11-20 13:17+0000\n"
 "Last-Translator: Ricky Tigg <ricky.tigg@gmail.com>\n"
 "Language-Team: Finnish <https://translate.fedoraproject.org/projects/dnf5/"

diff --git a/dnf5-plugins/builddep_plugin/po/fr.po b/dnf5-plugins/builddep_plugin/po/fr.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2024-05-07 13:36+0000\n"
 "Last-Translator: Pierre GRASSER <pierre.grasser@proton.me>\n"
 "Language-Team: French <https://translate.fedoraproject.org/projects/dnf5/"

diff --git a/dnf5-plugins/builddep_plugin/po/it.po b/dnf5-plugins/builddep_plugin/po/it.po
@@ -6,7 +6,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-06-19 03:39+0000\n"
+"POT-Creation-Date: 2025-07-26 03:48+0000\n"
 "PO-Revision-Date: 2025-04-25 21:09+0000\n"
 "Last-Translator: Salvatore Cocuzza <info@salvatorecocuzza.it>\n"
 "Language-Team: Italian <https://translate.fedoraproject.org/projects/dnf5/"