feat(core): implement incremental indexing#123
Merged
Conversation
- Implement delete() in LanceDB store using SQL predicate - Add new file detection to detectChangedFiles() - Handle deleted files in update() method - Clean up orphaned documents when symbols are removed - Add comprehensive tests for incremental update scenarios Closes #122
579d8f5 to
bece9e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the existing
update()method to actually work. The infrastructure was already there, we just needed to wire it up.Changes
1. Implement delete in vector store
delete()using LanceDB SQL predicate (id IN (...))2. Add new file detection
detectChangedFiles()now returns{ changed, added, deleted }3. Update method improvements
Test Results
Usage
Closes #122