This repository was archived by the owner on Mar 5, 2026. It is now read-only.
fixes performance issues and output file#12
Open
tylerthehaas wants to merge 31 commits intolyqht:mainfrom
Open
fixes performance issues and output file#12tylerthehaas wants to merge 31 commits intolyqht:mainfrom
tylerthehaas wants to merge 31 commits intolyqht:mainfrom
Conversation
lyqht
reviewed
Sep 3, 2025
Owner
lyqht
left a comment
lyqht
left a comment
There was a problem hiding this comment.
Code changes look good, left some comments
Comment on lines
+1
to
+2
| name: 'DeepL API Translate Github Action' | ||
| author: 'Tyler Haas' |
| }, | ||
| "profile": { | ||
| "intro": "What is up for snacks later?" | ||
| "admin": { |
Owner
There was a problem hiding this comment.
is this your project's json file? 😂
I would prefer it if this playground nested.json simpler and not as extensive. Let's keep it to max of 60 lines so that it's easier for users to understand it.
…ptions parameter of the translateText call to DeepL-Node
…ts, and adjust documentation in action.yml accordingly.
…19 translation functionality in main.test.ts
…e destructuring for clarity and maintainability.
Added new `model_type` Option
…ex.ts for HTTP requests
…tions for cleaner code and improved maintainability. Added Unit tests for updated index.ts
…nce validation. Update index.ts to utilize the new function signature. Add comprehensive unit tests for timeout handling in utils.test.ts and index.test.ts.
Check out PR head refs inside the action, diff source files against the base branch, and patch translated outputs incrementally so locale updates stop failing on dirty worktrees. Made-with: Cursor
Add an optional base_ref input so branch-restricted workflows can diff source files against an explicit branch such as release/leapfrog instead of relying only on pull request metadata. Made-with: Cursor
Diff source files against the PR branch's merge-base with the configured base branch so unrelated upstream locale changes are not retransmitted to DeepL. Made-with: Cursor
Use the workflow repository URL instead of the checked-out fork remote so incremental PR translations compare against the actual base branch and keep an origin fallback when that metadata is unavailable. Made-with: Cursor
…eprocessing options. Update translateTexts to use replaceParameterStringsInJSONValueWithKeepTags as default preprocess and limit batch size for translations.
…g start/end tags gracefully. Add unit tests to verify behavior for inline no-translate blocks and ensure proper translation of surrounding text.
Fix/incremental pr translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this I noticed that large json files with a lot of strings being translated to multiple languages (14 in our case) was taking a very long time (over an hour). This was due to sending one string per request and waiting for each response before sending the next string to be translated.
This PR changes that to the following approach: