Skip to content

[Patch] [BugFix][Event] The new event logic is adapted to SSR. #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

[Patch] [BugFix][Event] The new event logic is adapted to SSR. #3969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 52 additions & 33 deletions core/renderer/dom/vdom/radon/radon_node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ void RadonNode::MarkChildStyleDirtyRecursively(bool mark_whole_tree) {
}

void RadonNode::ProcessEvents() {
if (tasm_ &&
if (element() && tasm_ &&
(tasm_->EnableEventHandleRefactor() || tasm_->IsEmbeddedModeOn())) {
if (!static_events().empty() || !global_bind_events().empty()) {
for (const auto& static_event : static_events()) {
Expand Down Expand Up @@ -839,47 +839,66 @@ void RadonNode::SetEventListeners(
is_capture_catch || is_bubble_catch, is_global_bind);

if (is_js_event) {
const auto& callback = event_entry.second->function();
// remove the listener firstly to adapt rebind
element()->RemoveEventListener(
name, std::make_unique<event::ClosureEventListener>(
[](lepus::Value args) {}, event_options,
event::ClosureEventListener::ClosureType::kJS));
element()->AddEventListener(
name,
std::make_unique<event::ClosureEventListener>(
[tasm = tasm_, callback](lepus::Value args) {
const auto& args_array = args.Array();
if (args.IsArray() && args_array->size() == 2) {
const auto& event_info = args_array->get(0);
const auto& event_detail = args_array->get(1);
const auto& event_info_array = event_info.Array();
if (event_info.IsArray() && event_info_array->size() == 2) {
const auto& call_method_name =
event_info_array->get(0).Bool();
const auto& page_name_or_component_id =
event_info_array->get(1).StdString();
auto message = lepus::CArray::Create();
message->emplace_back(page_name_or_component_id);
message->emplace_back(callback);
// info be ShallowCopy first to avoid to be marked const.
message->emplace_back(lepus_value::ShallowCopy(event_detail));
auto event = fml::MakeRefCounted<runtime::MessageEvent>(
call_method_name
? runtime::kMessageEventTypeSendPageEvent
: runtime::kMessageEventTypePublishComponentEvent,
runtime::ContextProxy::Type::kCoreContext,
runtime::ContextProxy::Type::kJSContext,
std::make_unique<pub::ValueImplLepus>(
lepus::Value(std::move(message))));
tasm->DispatchMessageEvent(std::move(event));
bool is_piper_event = event_entry.second->is_piper_event();
if (is_piper_event) {
const auto& piper_event_vec = *event_entry.second->piper_event_vec();
element()->AddEventListener(
name,
std::make_unique<event::ClosureEventListener>(
[tasm = tasm_, piper_event_vec](lepus::Value args) {
for (const auto& event : piper_event_vec) {
const auto& func_name = event.piper_func_name_.str();
auto func_args = event.piper_func_args_;
tasm->TriggerLepusBridgeAsync(func_name, func_args);
}
}
},
event_options, event::ClosureEventListener::ClosureType::kJS));
},
event_options, event::ClosureEventListener::ClosureType::kJS));
} else {
const auto& callback = event_entry.second->function();
element()->AddEventListener(
name,
std::make_unique<event::ClosureEventListener>(
[tasm = tasm_, callback](lepus::Value args) {
const auto& args_array = args.Array();
if (args.IsArray() && args_array->size() == 2) {
const auto& event_info = args_array->get(0);
const auto& event_detail = args_array->get(1);
const auto& event_info_array = event_info.Array();
if (event_info.IsArray() && event_info_array->size() == 2) {
const auto& call_method_name =
event_info_array->get(0).Bool();
const auto& page_name_or_component_id =
event_info_array->get(1).StdString();
auto message = lepus::CArray::Create();
message->emplace_back(page_name_or_component_id);
message->emplace_back(callback);
// info be ShallowCopy first to avoid to be marked const.
message->emplace_back(
lepus_value::ShallowCopy(event_detail));
auto event = fml::MakeRefCounted<runtime::MessageEvent>(
call_method_name
? runtime::kMessageEventTypeSendPageEvent
: runtime::kMessageEventTypePublishComponentEvent,
runtime::ContextProxy::Type::kCoreContext,
runtime::ContextProxy::Type::kJSContext,
std::make_unique<pub::ValueImplLepus>(
lepus::Value(std::move(message))));
tasm->DispatchMessageEvent(std::move(event));
}
}
},
event_options, event::ClosureEventListener::ClosureType::kJS));
}
} else {
#if ENABLE_LEPUSNG_WORKLET
const auto& lepus_func = event_entry.second->lepus_function();
const auto& lepus_script = event_entry.second->lepus_script();
// remove the listener firstly to adapt rebind
element()->RemoveEventListener(
name, std::make_unique<event::ClosureEventListener>(
[](lepus::Value args) {}, event_options,
Expand Down
108 changes: 92 additions & 16 deletions core/template_bundle/template_codec/binary_decoder/element_binary_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
#include "core/renderer/dom/fiber/text_element.h"
#include "core/renderer/dom/fiber/view_element.h"
#include "core/renderer/dom/fiber/wrapper_element.h"
#include "core/renderer/events/closure_event_listener.h"
#include "core/renderer/template_assembler.h"
#include "core/renderer/utils/base/element_template_info.h"
#include "core/runtime/piper/js/runtime_constant.h"
#include "core/template_bundle/template_codec/binary_decoder/binary_decoder_trace_event_def.h"
#include "core/template_bundle/template_codec/template_binary.h"

Expand Down Expand Up @@ -159,13 +161,13 @@ bool ElementBinaryReader::DecodeElementRecursively(
break;

case ElementSectionEnum::ELEMENT_EVENTS:
if (!DecodeEventsSection(element)) {
if (!DecodeEventsSection(tasm, element)) {
return false;
}
break;

case ElementSectionEnum::ELEMENT_PIPER_EVENTS:
if (!DecodePiperEventsSection(element)) {
if (!DecodePiperEventsSection(tasm, element)) {
return false;
}
break;
Expand Down Expand Up @@ -268,36 +270,85 @@ bool ElementBinaryReader::DecodeClassesSection(
}

bool ElementBinaryReader::DecodeEventsSection(
fml::RefPtr<FiberElement>& element) {
TemplateAssembler* tasm, fml::RefPtr<FiberElement>& element) {
TRACE_EVENT(LYNX_TRACE_CATEGORY, ELEMENT_BINARY_READER_DECODE_EVENTS_SECTION);
DECODE_COMPACT_U32(size);
for (uint32_t i = 0; i < size; ++i) {
DECODE_U8(type);
DECODE_U8(type_enum);
DECODE_STR(name);
DECODE_STR(value);
const auto& event_string =
GetEventStringType(static_cast<EventTypeEnum>(type));
if (event_string.str().empty()) {
DECODE_STR(callback);
const auto& type =
GetEventStringType(static_cast<EventTypeEnum>(type_enum));
if (type.str().empty()) {
return false;
}
element->SetJSEventHandler(std::move(name), event_string, std::move(value));
element->SetJSEventHandler(name, type, callback);

if (tasm->EnableEventHandleRefactor() || tasm->IsEmbeddedModeOn()) {
bool is_capture = type.str() == EVENT_TYPE_CAPTURE;
bool is_capture_catch = type.str() == EVENT_TYPE_CAPTURE_CATCH;
bool is_bubble_catch = type.str() == EVENT_TYPE_CATCH;
bool is_global_bind = type.str() == EVENT_TYPE_GLOBAL;
auto event_options = event::EventListener::Options(
is_capture || is_capture_catch, false, false, false,
is_capture_catch || is_bubble_catch, is_global_bind);
auto handler_name = callback.str();
// remove the listener firstly to adapt rebind
element->RemoveEventListener(
name.str(), std::make_unique<event::ClosureEventListener>(
[](lepus::Value args) {}, event_options,
event::ClosureEventListener::ClosureType::kJS));
element->AddEventListener(
name.str(),
std::make_unique<event::ClosureEventListener>(
[tasm, handler_name](lepus::Value args) {
const auto& args_array = args.Array();
if (args.IsArray() && args_array->size() == 2) {
const auto& event_info = args_array->get(0);
const auto& event_detail = args_array->get(1);
const auto& event_info_array = event_info.Array();
if (event_info.IsArray() && event_info_array->size() == 2) {
const auto& call_method_name =
event_info_array->get(0).Bool();
const auto& page_name_or_component_id =
event_info_array->get(1).StdString();
auto message = lepus::CArray::Create();
message->emplace_back(page_name_or_component_id);
message->emplace_back(handler_name);
// info be ShallowCopy first to avoid to be marked const.
message->emplace_back(
lepus_value::ShallowCopy(event_detail));
auto event = fml::MakeRefCounted<runtime::MessageEvent>(
call_method_name
? runtime::kMessageEventTypeSendPageEvent
: runtime::kMessageEventTypePublishComponentEvent,
runtime::ContextProxy::Type::kCoreContext,
runtime::ContextProxy::Type::kJSContext,
std::make_unique<pub::ValueImplLepus>(
lepus::Value(std::move(message))));
tasm->DispatchMessageEvent(std::move(event));
}
}
},
event_options, event::ClosureEventListener::ClosureType::kJS));
}
}
return true;
}

bool ElementBinaryReader::DecodePiperEventsSection(
fml::RefPtr<FiberElement>& element) {
TemplateAssembler* tasm, fml::RefPtr<FiberElement>& element) {
TRACE_EVENT(LYNX_TRACE_CATEGORY,
ELEMENT_BINARY_READER_DECODE_PIPER_EVENTS_SECTION);
DECODE_COMPACT_U32(size);
for (uint32_t i = 0; i < size; ++i) {
DECODE_U8(type);
DECODE_U8(type_enum);
DECODE_STR(name);
DECODE_VALUE(value);

const auto& event_string =
GetEventStringType(static_cast<EventTypeEnum>(type));
if (event_string.str().empty()) {
const auto& type =
GetEventStringType(static_cast<EventTypeEnum>(type_enum));
if (type.str().empty()) {
return false;
}

Expand All @@ -314,8 +365,33 @@ bool ElementBinaryReader::DecodePiperEventsSection(
BASE_STATIC_STRING(PiperEventContent::kPiperFuncArgs))});
});

element->data_model()->SetStaticEvent(event_string, std::move(name),
std::move(piper_event_content));
element->data_model()->SetStaticEvent(type, name, piper_event_content);

if (tasm->EnableEventHandleRefactor() || tasm->IsEmbeddedModeOn()) {
bool is_capture = type.str() == EVENT_TYPE_CAPTURE;
bool is_capture_catch = type.str() == EVENT_TYPE_CAPTURE_CATCH;
bool is_bubble_catch = type.str() == EVENT_TYPE_CATCH;
bool is_global_bind = type.str() == EVENT_TYPE_GLOBAL;
auto event_options = event::EventListener::Options(
is_capture || is_capture_catch, false, false, false,
is_capture_catch || is_bubble_catch, is_global_bind);
// remove the listener firstly to adapt rebind
element->RemoveEventListener(
name.str(), std::make_unique<event::ClosureEventListener>(
[](lepus::Value args) {}, event_options,
event::ClosureEventListener::ClosureType::kJS));
element->AddEventListener(
name.str(),
std::make_unique<event::ClosureEventListener>(
[tasm, piper_event_content](lepus::Value args) {
for (const auto& event : piper_event_content) {
const auto& func_name = event.first.str();
const auto& func_args = event.second;
tasm->TriggerLepusBridgeAsync(func_name, func_args);
}
},
event_options, event::ClosureEventListener::ClosureType::kJS));
}
}

return true;
Expand Down
6 changes: 4 additions & 2 deletions core/template_bundle/template_codec/binary_decoder/element_binary_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ class ElementBinaryReader : public LynxBinaryBaseCSSReader {
bool DecodeIDSelectorSection(fml::RefPtr<FiberElement>& element);
bool DecodeInlineStylesSection(fml::RefPtr<FiberElement>& element);
bool DecodeClassesSection(fml::RefPtr<FiberElement>& element);
bool DecodeEventsSection(fml::RefPtr<FiberElement>& element);
bool DecodePiperEventsSection(fml::RefPtr<FiberElement>& element);
bool DecodeEventsSection(TemplateAssembler* tasm,
fml::RefPtr<FiberElement>& element);
bool DecodePiperEventsSection(TemplateAssembler* tasm,
fml::RefPtr<FiberElement>& element);
bool DecodeAttributesSection(fml::RefPtr<FiberElement>& element);
bool DecodeDatasetSection(fml::RefPtr<FiberElement>& element);
bool DecodeParsedStylesSection(fml::RefPtr<FiberElement>& element);
Expand Down
Loading