[Patch] [BugFix][Android] Fix the issue of not setting font features when using cached fonts. #3958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng cached fonts. Previously, `font-feature-settings` were part of the `FontSettingsKey` used for caching `Typeface` objects. This was incorrect because the cached `Typeface` itself does not retain these settings. As a result, when a font was retrieved from the cache, the feature settings were lost. This commit decouples font feature settings from the cache key. The `fontFeatureSettings` are now applied directly to the `TextPaint` object after the `Typeface` is retrieved, regardless of whether it came from the cache or was newly created. This ensures that font features are consistently applied in all scenarios, fixing the rendering bug for cached fonts. issue:m-6795375750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.