Skip to content

Conversation

@FrendyChen
Copy link

Change-Id: I1a985909e731028f0b555ca7e1681831e66e954b

@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for lynx-doc ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dfe3989
🔍 Latest deploy log https://app.netlify.com/projects/lynx-doc/deploys/68d28cc724ea7000083627aa
😎 Deploy Preview https://deploy-preview-395--lynx-doc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -0,0 +1,518 @@
From d5868a22f8e38514a6ebe34d9d131547ccc28a90 Mon Sep 17 00:00:00 2001
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件需要提交到 git 里吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要,我删掉

@FrendyChen FrendyChen force-pushed the p/lynx_value_document branch from b94a0cd to 6c157bf Compare September 22, 2025 12:57
@@ -0,0 +1,225 @@
# LynxValue
LynxValue 是 Lynx 提供的一套 C Value API,支持 LynxSDK 与 Lynx 客户端接口使用方相互传递数据。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"开发者在什么场景下需要用到这一组 API" 这个信息在哪里能看得到吗

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议把方案设计中的 Motivation 和 使用指南中抽取出部分信息在这里介绍一下。

```c
lynx_api_status lynx_value_typeof(lynx_api_env env,
lynx_value value,
lynx_value_type* result);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里每一个 API 的介绍比较简单,可以参考 https://lynxjs.org/api/engine/element-api/__AddInlineStyle.html 这些 API,提供入参介绍,返回值介绍和代码示例。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同时需要补充兼容性表格,这些 API 是哪个 Lynx Engine 版本引入的。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

@@ -0,0 +1,225 @@
# LynxValue
LynxValue is a set of C Value APIs provided by Lynx, supporting data exchange between LynxSDK and Lynx client interface users.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LynxValue is a set of C Value APIs provided by Lynx, supporting data exchange between LynxSDK and Lynx client interface users.
LynxValue is a set of C Value APIs provided by Lynx, supporting data exchange between Lynx Engine and Lynx client interface users.

What is "Lynx client interface users"? Please only uses terms defined from spec and linked to spec on high-level introduction like https://lynxjs.org/guide/start/integrate-with-existing-apps.html?platform=ios#configuring-deps

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also introduce "Lynx Value" as a new definition in the Spec while adding the APIs

Change-Id: I1a985909e731028f0b555ca7e1681831e66e954b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants