Feat/add rails 8.1#1684
Draft
hatsu38 wants to merge 6 commits into
Draft
Conversation
- sqlite3: drop version constraint so each Appraisal can pin its own version (consistent with how pg and mysql2 are declared). Required for sqlite3 ~> 2.x used by Rails 8. - mongoid: drop the `< 8` upper bound. Rails 8 requires activemodel 8.x, which is incompatible with mongoid 7.x. Without these changes, generating Rails 8 gemfiles via Appraisals fails with conflicting requirements.
minitest-rails follows the Rails major.minor (e.g. minitest-rails 8.1.x requires railties ~> 8.1). Pinning it in Gemfile prevents Appraisals from overriding it for different Rails versions. Bundler now resolves the matching minitest-rails version per Rails appraisal, with each Appraisals block specifying the version explicitly.
Each Rails 8 block pins: - sqlite3 ~> 2.1 (required by Rails 8 active_record adapter) - minitest-rails matching the Rails major.minor Generated gemfiles via: bundle exec appraisal rails-8-0 install bundle exec appraisal rails-8-1 install
- gemfile: include rails_8_0.gemfile and rails_8_1.gemfile
- ruby: include 4.0
- exclude:
- Ruby 2.7 / 3.0 / 3.1 / 3.2 for Rails 8.x
(Rails 8 requires Ruby 3.2+, but 3.2 is also EOL)
- Older Rails (4.2 / 5.x / 6.0 / 7.0) for Ruby 4.0
(Ruby 4.0 is supported only on Rails 8 series here)
Rails 7.1 deprecated `ActiveRecord::Migration.check_pending!` in favor of `check_all_pending!`. Rails 8 removed `check_pending!` entirely. Use `check_all_pending!` when available, falling back to `check_pending!` on older Rails versions (4.2 through 7.0).
Ruby 4.0 removed `CGI.parse`. Use `URI.decode_www_form` instead and shape the result as `Hash<String, Array<String>>` to keep the existing callers (which expect array values) working without changes. Compatible with Ruby 2.7 through 4.0.
hatsu38
force-pushed
the
feat/add-rails-8.1
branch
from
e0e0ede to
7ba5cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.