Skip to content

atomic PR which makes Blockquotes and Foonotes easier to read in Dark… #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

atomic PR which makes Blockquotes and Foonotes easier to read in Dark… #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/_includes/layouts/post.vto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ bodyClass: body-post
{{ include "templates/post-details.vto" }}
</header>

{{ if toc.length }}
{{ if toc?.length }}
<nav class="toc">
<h2>{{ i18n.nav.toc }}</h2>
<ol>
Expand All @@ -36,7 +36,7 @@ bodyClass: body-post
{{ content }}
</div>

{{ if it.footnotes.length }}
{{ if it.footnotes?.length }}
<aside role="note" class="footnotes">
<dl>
{{ for note of footnotes }}
Expand Down
9 changes: 9 additions & 0 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@
--color-link-hover: var(--color-dim);
}

[data-theme="dark"] main blockquote {
font-size: 0.95rem;
color: #f1f1f1;
}

[data-theme="dark"] .footnote {
color: #f1f1f1;
}

Copy link
Member

@oscarotero oscarotero Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see that footnotes could be easier to read in dark mode. But these changes should be applied to the Lume's design system (in the .footnotes component: https://github.com/lumeland/ds/blob/main/src/components/footnotes.css).

And the same for blockquotes: https://github.com/lumeland/ds/blob/main/src/components/blockquote.css

And both colors and font sizes must be applied using the existing CSS variables, so people can override them to customize the appearance.

Can you remove the changes in this file? So we can apply them in the lumeland/ds package.

/* Page layout */
main {
padding: var(--row-gap-medium) 0;
Expand Down