Skip to content

Conversation

@ras0q
Copy link
Contributor

@ras0q ras0q commented Sep 25, 2025

Description

When using Japanese fonts such as Zen Maru Gothic, the Japanese subset is not installed and will not be applied.

Since font-face does not necessarily have a subset name, I modified the regular expression.

e.g. https://fonts.googleapis.com/css2?family=Zen+Maru+Gothic:wght@700&display=swap

reproduction: https://github.com/ras0q/lume-repro-google-fonts-missing-subsets/tree/main/after

Related Issues

Fixes #784

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
      • Q: What kind of test is required?
    • Run deno fmt to fix the code format before commit.
    • [j] Document any change in the CHANGELOG.md.

@oscarotero oscarotero merged commit 3f54c9a into lumeland:main Sep 25, 2025
4 of 6 checks passed
@oscarotero
Copy link
Member

Oh, good catch! Thank you!
(don't worry about the failing tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(google_fonts): missing subsets using Japanese fonts

2 participants