-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Upgrades 2025-12, pnpm, tailwinds 4 #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b7cbb86 to
3c9a0ac
Compare
3c9a0ac to
fba72d1
Compare
b654d84 to
97b4efa
Compare
4984f21 to
38f70f7
Compare
8a65359 to
78642e8
Compare
…in release-please.
78642e8 to
57b2548
Compare
Storybook deployed with Cloudflare Pages ☁️ 📖 🚀Storybook
Built from commit 044ccd0 |
|
This is going to take more time or maybe it won't work. Sass and tailwinds 4 don't seem to work together because sass has a backward compatible @import and tailwinds relies on it being passed to the tailwinds plugin. |
5d2cf60 to
1fbada4
Compare
|
The failing cloudflare deployment is fine. We're going to start to deploy using github actions just like the other project once this is merged. This one already does the deployment that way so the URL in the PR comment is correct to check. |
I think we can get rid of SASS since modern css has nesting already, besides we don't write much custom styles anyway |
|
Yea I am only using sass in order to create the old main.css and to allow the -v4 files to share some code. The actual storybook and components should no longer be using sass. |
Ticket ID
Description