Skip to content

Conversation

@richtera
Copy link
Collaborator

Ticket ID

Description

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2025

Deploying tools-web-components with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39e8d6c
Status:🚫  Build failed.

View logs

@richtera richtera force-pushed the upgrades/2025-12 branch 3 times, most recently from b7cbb86 to 3c9a0ac Compare December 16, 2025 14:42
@richtera richtera marked this pull request as draft January 5, 2026 09:25
@richtera richtera changed the base branch from main to fix/repair-axe-core January 6, 2026 10:00
@richtera richtera marked this pull request as ready for review January 6, 2026 10:00
@richtera richtera force-pushed the fix/repair-axe-core branch from 4984f21 to 38f70f7 Compare January 6, 2026 10:45
@richtera richtera force-pushed the upgrades/2025-12 branch 2 times, most recently from 8a65359 to 78642e8 Compare January 6, 2026 10:49
Base automatically changed from fix/repair-axe-core to main January 6, 2026 10:52
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Storybook deployed with Cloudflare Pages ☁️ 📖 🚀

Storybook

Built from commit 044ccd0

@richtera richtera marked this pull request as draft January 6, 2026 14:26
@richtera
Copy link
Collaborator Author

richtera commented Jan 6, 2026

This is going to take more time or maybe it won't work. Sass and tailwinds 4 don't seem to work together because sass has a backward compatible @import and tailwinds relies on it being passed to the tailwinds plugin.

@richtera richtera changed the title fix: Upgrades 2025-12 feat: Upgrades 2025-12, pnpm, tailwinds 4 Jan 6, 2026
@richtera richtera marked this pull request as ready for review January 6, 2026 16:28
@richtera
Copy link
Collaborator Author

richtera commented Jan 6, 2026

The failing cloudflare deployment is fine. We're going to start to deploy using github actions just like the other project once this is merged. This one already does the deployment that way so the URL in the PR comment is correct to check.

@dzbo
Copy link
Collaborator

dzbo commented Jan 7, 2026

This is going to take more time or maybe it won't work. Sass and tailwinds 4 don't seem to work together because sass has a backward compatible @import and tailwinds relies on it being passed to the tailwinds plugin.

I think we can get rid of SASS since modern css has nesting already, besides we don't write much custom styles anyway

@richtera
Copy link
Collaborator Author

richtera commented Jan 7, 2026

Yea I am only using sass in order to create the old main.css and to allow the -v4 files to share some code. The actual storybook and components should no longer be using sass.

@richtera richtera merged commit c5dea20 into main Jan 8, 2026
8 of 9 checks passed
@richtera richtera deleted the upgrades/2025-12 branch January 8, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants