Fix absolute source paths in ROOT dictionary autoload annotations#2
Open
olantwin wants to merge 1 commit into
Open
Fix absolute source paths in ROOT dictionary autoload annotations#2olantwin wants to merge 1 commit into
olantwin wants to merge 1 commit into
Conversation
Pass bare header names to ROOT_GENERATE_DICTIONARY instead of absolute
paths via ${CMAKE_CURRENT_LIST_DIR}. Absolute paths get embedded in the
dictionary's $clingAutoload$ annotations inside the shared library,
causing errors at runtime when the source directory no longer exists
(e.g. when deployed on CVMFS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass bare header names to ROOT_GENERATE_DICTIONARY instead of absolute paths via ${CMAKE_CURRENT_LIST_DIR}. Absolute paths get embedded in the dictionary's$clingAutoload$ annotations inside the shared library, causing errors at runtime when the source directory no longer exists (e.g. when deployed on CVMFS).
In the SHiP stack this works (built out of source), but of course this might need adjusting for other cases.