Fixed Signal SVG icon #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior signal svg was throwing console errors, instead of figuring out what was borking in the existing svg, I grabbed the official logo svg from https://signal.org/brand/ and tweaked the color and size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the existing SVG icon for Signal was throwing an error in the console:
Error: <path> attribute d: Unexpected end of attribute. Expected number, "…7,0,0,0,512,226s".Not a huge deal, but it was nagging at me. I grabbed the official SVG logo from Signal and replaced the existing icon. I tweaked the size and fill color to match the other icons.