add luadata_clear for netfilter & xtable #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneto
reviewed
Aug 7, 2025
lneto
reviewed
Aug 7, 2025
lib/luaxtable.c
Outdated
| int ret = lua_toboolean(L, -1); | ||
| lua_getfield(L, -2, "hotdrop"); | ||
| par->hotdrop = lua_toboolean(L, -1); | ||
| luadata_clear(xtable->skb); |
Contributor
There was a problem hiding this comment.
you should clear just after the call.. on either case.. success or error.. perhaps a better approach is to move the cleanup to luaxtable_call..
Contributor
Author
There was a problem hiding this comment.
fixed. but there has some typecast in original commit. so i have to add an extra function to typecast it back, otherwise the luadata_clear wouldn't accept it.
Contributor
There was a problem hiding this comment.
why do you need a function? just put a typecast inline..
lneto
reviewed
Aug 7, 2025
lneto
reviewed
Aug 8, 2025
|
|
||
| #define luaxtable_call(L, op, xtable, skb, par, info, opt) \ | ||
| ((luaxtable_pushparams(L, par, xtable, skb, opt) == -1) || (luaxtable_docall(L, xtable, info, op, 2, 1) == -1)) | ||
| ((luaxtable_pushparams(L, par, xtable, skb, opt) == -1) || (luaxtable_docall(L, xtable, info, op, 2, 1) == -1) || luaxtable_cleanup(xtable)) |
Contributor
There was a problem hiding this comment.
it will only be called in case of success, right? as I mentioned, both cases should be handled
Contributor
There was a problem hiding this comment.
IMHO, the best approach is to move the luadata_clear() call to luaxtable_docall() body..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but important change to the
luanetfilter_hook_cbfunction inlib/luanetfilter.c. The update ensures that thedatastructure is cleared before further processing, which can help prevent issues caused by stale or leftover data.luadata_clear(data);at the beginning of the function to ensure thedatastructure is reset before use.