-
Notifications
You must be signed in to change notification settings - Fork 40
Skel2hid #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Skel2hid #255
Conversation
|
@qrsikno2 I don't see you adding luahid in here.. https://github.com/luainkernel/lunatik/blob/master/bin/lunatik#L10 |
lib/luahid.c
Outdated
|
|
||
| #include <lunatik.h> | ||
|
|
||
| #include "luanetfilter.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is because i need to use the good macro developed by sheharyaar
lunatik_setstring(L, 1, user_driver, name, NAME_MAX);in Line 88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we should move this macro to lunatik.h
fixed |
lib/luahid.c
Outdated
| } | ||
| lunatik_setruntime(L, hid, hid); | ||
| lunatik_getobject(hid->runtime); | ||
| // pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does pass mean here? Btw, please don't use cpp comment style..
|
|
||
| //configure the driver's properties & callbacks | ||
| struct hid_driver *user_driver = &(hid->driver); | ||
| user_driver -> name = lunatik_checkalloc(L, NAME_MAX); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mind our code style.. when in doubt, use Linux's code style.. no space around ->
lib/luahid.c
Outdated
| struct hid_driver driver; | ||
| } luahid_t; | ||
|
|
||
| //kernel codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always refer to the original if you are borrowing something
17ac113 to
925bfd9
Compare
copy from
hid-genericto lunatik.