Skip to content

Conversation

rhiannonlynne
Copy link
Member

kurucz_sun was not scaled properly

@rhiannonlynne rhiannonlynne requested a review from yoachim July 15, 2025 17:51
Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider adding a unit test for kurucz_sun.gz and the other files in there. Especially since there isn't much documentation on what those files are or where one might use them.

@rhiannonlynne
Copy link
Member Author

Totally up for that, but do you mean just a unit test that unpacks the reflectance, multiplies by the kurucz_sun, and then calculates colors? Like in https://github.com/lsst/rubin_sim_notebooks/blob/main/photometry/solar_system_object_colors.ipynb but just for LSST?
(or I guess, at the start of the moving objects code, in order to calculate colors there)?

@rhiannonlynne rhiannonlynne changed the title Update rs_download_data to point to new movingObjects (2025-07-15) data SP-2453: Update rs_download_data to point to new movingObjects (2025-07-15) data Jul 16, 2025
@yoachim
Copy link
Member

yoachim commented Jul 18, 2025

Sure, just reading in the files, doing something simple with them and checking that the values are reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants