DM-43077: Convert all tasks to use CalibrateImageTask outputs #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
90c7b1d to
0cdbe67
Compare
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
0cdbe67 to
f6ec4cd
Compare
leeskelvin
reviewed
Oct 2, 2024
| ] | ||
| self.measurement.plugins["base_PixelFlags"].masksFpCenter = [ | ||
| "CLIPPED", | ||
| "SENSOR_EDGE", | ||
| "REJECTED", | ||
| "INEXACT_PSF", | ||
| "STREAK", | ||
| # "STREAK", |
There was a problem hiding this comment.
Although only a few lines away from the prior TODO, this probably also needs a TODO inline comment to ensure that it isn't missed when the time comes to uncomment this.
leeskelvin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.