Skip to content

Revamp Flask GUI layout with project state - #19

Open
lpurdy01 wants to merge 3 commits into
mainfrom
codex/implement-stage-1-web-gui-overhaul-svq7pc
Open

Revamp Flask GUI layout with project state#19
lpurdy01 wants to merge 3 commits into
mainfrom
codex/implement-stage-1-web-gui-overhaul-svq7pc

Conversation

@lpurdy01

Copy link
Copy Markdown
Owner

Summary

  • restructure the Flask templates into a top navigation bar, workflow sidebar, and staged panels for preview, setup, progress, and results
  • persist scenario uploads as reusable projects with reset/export routes while tightening field-map detection and SSE visual updates
  • expand the GUI documentation, agent guidance, and pytest coverage for project reuse, downloads, and layout behaviour

Testing

  • pytest tests/test_gui_flask.py

https://chatgpt.com/codex/tasks/task_e_68f87495d1c08331a54aefc27808404f

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/gui/app_flask.py Outdated
Comment on lines +155 to +158
output_path = Path(cleaned_path)
if not output_path.is_absolute():
output_path = scenario_path.parent / output_path

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve field-map outputs relative to solver working dir

When processing field-map events, the path from the log is rewritten relative to the uploaded scenario (output_path = scenario_path.parent / output_path). motor_sim interprets relative output paths relative to its current working directory (the repo root when launched via ./build/motor_sim), so logs such as outputs/domain_field.csv will actually be written under ./outputs, not beside the uploaded JSON. Because the GUI looks in the scenario directory instead, it never finds the CSV, so live previews and the final field-map download remain empty unless a scenario uses absolute paths. _collect_field_outputs applies the same assumption, compounding the problem after the run completes. Consider resolving relative paths against the process CWD (or using Path.cwd()), so default scenarios with relative outputs are discovered correctly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant