Add Stage 1 web GUI with previews and visualization controls - #18
Add Stage 1 web GUI with previews and visualization controls#18lpurdy01 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| field_outputs = _collect_field_outputs(spec, scenario_path.parent) | ||
| extra_downloads = [ | ||
| { | ||
| "category": "result", | ||
| "path": str(entry["path"]), | ||
| "label": f"Field map CSV ({entry['id']})" if entry.get("id") else entry["path"].name, | ||
| } | ||
| for entry in field_outputs | ||
| ] |
There was a problem hiding this comment.
Result CSV downloads point to non-existent files
The extra_downloads list is populated with field map CSVs using their actual paths under the uploaded scenario directory, but only the bare filename is exposed to the client. The /download handler resolves all result downloads against RESULTS_FOLDER, so clicking the generated “Field map CSV …” links after a run will request /download?category=result&filename=<csv> where no such file exists. Because the CSV is never copied into RESULTS_FOLDER, every link returns 404 even though the file was produced. Either copy the CSVs into the results directory or have the download route serve them from their real path.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f87495d1c08331a54aefc27808404f