fix: docker image not building #1724
Open
+3,168
−2,072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image is not currently building, it just gets stuck forever.
I think it's because of some npm scripts.
So, first I updated all dependencies within ranges with
npm update --save
, and then I updated puppeteer and sharp to their latest versions.Also, I took this opportunity to modernize the Dockerfile and make it much quicker to build.
Note I removed licensed, but I plan to bring it back once pkgxdev/pantry#9488 is completed.EDIT: done.