Skip to content

fix: notable not showing users for user-owned repositories #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipecrs
Copy link

@felipecrs felipecrs commented May 23, 2025

This fixes #1721:

image

@felipecrs
Copy link
Author

Just in case someone else needs this before @lowlighter gets around to merging it, you can use my fork:

- uses: felipecrs/metrics@master
  with:
    use_prebuilt_image: no

@mikey-
Copy link

mikey- commented May 26, 2025

Nice!

Copy link

@mikey- mikey- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I don't have any sway over whether this is merged, so please feel free to ignore me.

That said I do want to include your change into my fork & PR. However, before I do that - I'd like to understand the fix a little bit better. How does
this work? It seems like this only works when we want to show users for user-owned repositories, but when it's an organisation repo, it won't work.

Is that correct? or will this work for organisation owned repos too?

@felipecrs
Copy link
Author

felipecrs commented May 26, 2025

For orgs you should set plugin_notable_repositories: yes. See the documentation:

image

@mikey-
Copy link

mikey- commented May 28, 2025

Thank you king

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants