-
Notifications
You must be signed in to change notification settings - Fork 30
Otsca test #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Otsca test #398
Conversation
This can have lower priority to be merged. What still needs to be done:
Feel free to add more to-do's to improve this |
FPGA part is done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Siemen for working this, having a test framework for ot-sca <-> pentest framework does have a huge impact on the maintainability of the pentesting infrastructure :)
I've dropped a couple of comments. It seems that your changes broke the current SCA capture scripts (please see the CI). In order to merge this we would need to make sure that they still work.
Sadly I must admin defeat in that I couldn't get OpenTitan's lint targets work for this WORKSPACE so licenses and empty lines added manually for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Siemen. I'd suggest a couple of points before we can merge this:
- Can you please rebase the PR such that we see that CI passes?
- Would it be possible to add a very brief documentation to
test/penetrationtests
, i.e., a brief how to run this? - Could you please squash some of the commits? E.g., creating a new communication folder and then moving it again at the end?
- Would it be possible to move the default configs for the target/communication scripts outside of these functions?
68be907
to
c87d1a8
Compare
Make a bazel framework in ot-sca as extension of OpenTitan and add test scripts (pytests) from the host side for the penetrationtests. Signed-off-by: Siemen Dhooghe <[email protected]>
Add scripts on how to chain commands for each test of the current testOS, add a Bazel framework which extends the opentitan repo's, add test scripts to test the testOS from the host scripts.