Improve e2e lifecycle cleanup and PR workflow - #63
Open
bittermandel wants to merge 1 commit into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d0b20-784f-72d8-9a2d-52f1a5cfb32c Co-authored-by: Amp <amp@ampcode.com>
bittermandel
added a commit
that referenced
this pull request
Apr 27, 2026
) * ci(e2e): cancel concurrent runs and bound job timeout Adds a concurrency group keyed on workflow + ref so a new push to a PR cancels the in-flight run instead of queuing behind it. Restricts push triggers to main, expands PR triggers (opened/synchronize/reopened/ ready_for_review), and caps job runtime at 90 minutes so a wedged Kind or hung process can't burn an Actions runner indefinitely. * test(e2e): run cleanup on failure and use baseline namespace policy Three small robustness fixes to the e2e harness, ported from PR #63: - make test-e2e wraps the Go test invocation in trap cleanup EXIT so Kind teardown runs even when tests fail (previously the cleanup line was only reached on success). - The namespace is created via kubectl apply --dry-run=client | apply instead of kubectl create, so re-running the suite against an existing cluster doesn't fail with AlreadyExists. - Namespace policy switched from restricted to baseline. Neon pods need baseline (runAsUser=1000 etc.); restricted blocks them silently. - Teardown calls (pod, namespace) gain --ignore-not-found and --wait=false so partial failures don't stall AfterAll. make undeploy/uninstall pass ignore-not-found=true and undeploy is bounded with a 2-minute context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.