Use own packet handler instead of Mekanism's#111
Merged
QiuYe-123 merged 2 commits intolostmyself8:1.20.1from Jan 25, 2026
Merged
Use own packet handler instead of Mekanism's#111QiuYe-123 merged 2 commits intolostmyself8:1.20.1from
QiuYe-123 merged 2 commits intolostmyself8:1.20.1from
Conversation
QiuYe-123
added
type: bugfix
QiuYe-123
requested changes
Jan 25, 2026
Collaborator
QiuYe-123
left a comment
QiuYe-123
left a comment
There was a problem hiding this comment.
Run .\gradlew spotlessApply
Collaborator
|
can you port for 1.21.1? |
Author
I'll try it later |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / 目的
If multiple mods use Mixin to add message registrations in the Mekanism Packet Handler,
registrations may be added in a different order on the client and server,
which can lead to disconnections by using invalid decoder. This PR should fixed it.
Implementation Details / 实现细节
This issue was fixed by using the own Packet Handler instead of the Mekanism Packet Handler. Also removed MixinPacketHandler.
Additional Information / 附加信息
For example, a disconnect message occurs on the Reclamation modpack after clicking "Auto-sort" on machines from this mod, when this mod is added alongside Mekanism Extras:
I also have dumps of PacketHandler.class from both the client and the server after Mixin transformations.
I can provide them if needed.