conditional downloads #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return nil, fmt.Errorf("error downloading source: %s %s", uri, err) | ||
| } | ||
|
|
||
| current, err := os.ReadFile(filePath) |
Check failure
Code scanning / gosec
Potential file inclusion via variable Error
| // header with an ETag and If-Modified-Since with a Date are set, the | ||
| // latter is supposed to be ignored, but not all servers work like that. | ||
| if etag := response.Header.Get("ETag"); etag != "" { | ||
| output.WriteString(fmt.Sprintf("# ETag: %s\n", etag)) |
Check warning
Code scanning / gosec
Errors unhandled. Warning
| if etag := response.Header.Get("ETag"); etag != "" { | ||
| output.WriteString(fmt.Sprintf("# ETag: %s\n", etag)) | ||
| } else if date := response.Header.Get("Date"); date != "" { | ||
| output.WriteString(fmt.Sprintf("# Date: %s\n", date)) |
Check warning
Code scanning / gosec
Errors unhandled. Warning
| output.WriteString(fmt.Sprintf("# Date: %s\n", date)) | ||
| } | ||
|
|
||
| output.WriteString("\n") |
Check warning
Code scanning / gosec
Errors unhandled. Warning
| logger.Criticalf("Error closing file: %s\n", err) | ||
| } | ||
|
|
||
| if err := os.Chmod(tempPath, 0o644); err != nil { |
Check failure
Code scanning / gosec
Expect file permissions to be 0600 or less Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enhances downloading of hosts files/blocklists by adding support for conditional download based on
ETagorDateheaders.Temporary files are also now used when downloading hosts files/blocklists.