Add minting algorithm to dposV3 contract #1334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlight
requested changes
Jul 15, 2019
builtin/plugins/coin/coin.go
Outdated
|
|
||
|
|
||
| // MintToDPOS adds loom coins to the loom coin DPOS contract balance, and updates the total supply. | ||
| func (c *Coin) MintToDPOS(ctx contract.Context, req *MintToDPOSRequest) error { |
There was a problem hiding this comment.
Don't need this, the DPOS contract will only mint ERC20
cmd/loom/dposV3_commands.go
Outdated
| func MintERC20CmdV3() *cobra.Command { | ||
| var flags cli.ContractCallFlags | ||
| cmd := &cobra.Command{ | ||
| Use: "mint-erc20 [amount] [erc20token Address]", |
builtin/plugins/dposv3/dpos.go
Outdated
|
|
||
| func loadERC20Token(ctx contract.Context, tokenAddr loom.Address) (*erc20Context, error) { | ||
| erc20 := newERC20Context(ctx, tokenAddr) | ||
| return erc20,nil |
builtin/plugins/dposv3/dpos.go
Outdated
| } | ||
|
|
||
| //MintVouchers method to the DPOS contract that can be called only by delegators - Mints Loom Coin | ||
| func (c *DPOS) MintVoucher(ctx contract.Context, req *MintVoucherRequest) error { |
builtin/plugins/dposv3/dpos.go
Outdated
| } | ||
|
|
||
| //MintVouchersERC20 method to the DPOS contract that can be called only by delegators - Mints Generic ERC20 Token | ||
| func (c *DPOS) MintVoucherERC20(ctx contract.Context, req *MintVoucherERC20Request) error { |
There was a problem hiding this comment.
Check req.Amount != nil and greater than zero before doing anything else.
There was a problem hiding this comment.
And this new method should return an error if dpos:v3.6 feature is not enabled.
There was a problem hiding this comment.
Added nil check for VoucherTokenAddress as well.
builtin/plugins/dposv3/dpos.go
Outdated
| sender := ctx.Message().Sender | ||
| for _, d := range delegations { | ||
| if loom.UnmarshalAddressPB(d.Delegator).Compare(sender) == 0 { | ||
| erc20, err := loadERC20Token(ctx, loom.UnmarshalAddressPB(req.TokenAddress)) |
There was a problem hiding this comment.
VoucherTokenAddress should be stored in state.Params.VoucherTokenAddress, not passed in the request.
…ontract balance, and updates the total supply.
2)Add req.Amount=nil or zero check
suhasagg
force-pushed
the
Add_Minting_Algorithm_To_DPOS_Contract
branch
from
d4777f7 to
33bb821
Compare
…oomnetwork/loomchain into Add_Minting_Algorithm_To_DPOS_Contract
In this case minting does not take place as request must come from a delegator
(require msg.sender == dpos) This is for access control for minting SampleERC20Token.sol
|
https://ci.kanwisher.com/blue/organizations/jenkins/loom-sdk-pipeline-prbuilder/detail/loom-sdk-pipeline-prbuilder/5138/pipeline/ Replayed build is building fine. |
|
Will revisit this at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minting algorithm to dposV3 contract
Adds new MintVouchers method to the DPOS contract that can be called only by delegators