Fix tests and lock Yarn version#741
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project configuration by specifying a package manager and upgrading the chai-http dependency to version 4.3.0. It also enables server-side testing by uncommenting relevant imports and setup code, and adds a cleanup step to restore sinon state after each test. Feedback includes a recommendation to update the corresponding @types/chai-http package for type safety and a suggestion to reorder imports in the test files to follow standard practices.
|
|
||
| const chaiHttp = require("chai-http") | ||
| chai.use(chaiHttp) | ||
|
|
||
| import "../src/actions/index" |
There was a problem hiding this comment.
Import statements should be grouped together at the top of the file, before other code like variable declarations or function calls. This improves readability and follows standard TypeScript practices.
| const chaiHttp = require("chai-http") | |
| chai.use(chaiHttp) | |
| import "../src/actions/index" | |
| import "../src/actions/index" | |
| const chaiHttp = require("chai-http") | |
| chai.use(chaiHttp) |
mnvsngv
force-pushed
the
feat/fix-test-infra
branch
from
75b7a66 to
24741be
Compare
| import "./test_json_detail_stream" | ||
| import "./test_oauth_action" | ||
| // import "./test_server" | ||
| import "./test_server" |
There was a problem hiding this comment.
I'm adding back the test_server tests so that I can add test cases for OAuth in my next PR.
| import "../src/actions/jira/test_jira" | ||
| import "../src/actions/kloudio/test_kloudio" | ||
| import "../src/actions/marketo/test_marketo" | ||
| // import "../src/actions/marketo/test_marketo" |
There was a problem hiding this comment.
Marketo isn't actively maintained and its tests are failing after I added the test_server. So I'm commenting those out.
| "node": "20.16.0", | ||
| "yarn": ">=1.19.1" | ||
| }, | ||
| "packageManager": "yarn@1.19.1", |
There was a problem hiding this comment.
This allows Corepack to pick up the correct version of Yarn to be used for local development.
1 participant
This PR is preparing for a subsequent PR to fix an OAuth vulnerability. I'm fixing up the test infrastructure first so that I can include new test cases in the next PR.