Skip to content

Set viewParameter is missing #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set viewParameter is missing #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion EventListener/ViewTemplateListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ public function onPreContentView(PreContentViewEvent $event)
// The resulted array is casted to object (stdClass) for convenient use in templates.
// Parameter name will be unchanged. Parameters returned by provider will then be "namespaced" by the parameter name.
$provider = $this->parameterProviders[$param['provider']];
$param = (object) $provider->getViewParameters($this->generateConfigurableView($view), $paramProviderOptions);
$param = $provider->getViewParameters($this->generateConfigurableView($view), $paramProviderOptions);
$view->setParameters($param);
Copy link
Owner

@lolautruche lolautruche Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed as setParameters() is called a few lines below.

} elseif (is_array($param) && isset($param['expression'])) {
$configurableView = $this->generateConfigurableView($view);
$content = $configurableView->getContent();
Expand Down