Skip to content

Add security.protocol=SSL when ssl is true #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gquintana wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Add security.protocol=SSL when ssl is true #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4bb44
Add security.protocol=SSL when ssl is true
Jan 25, 2017
c0d7d9b
Don't overwrite security_protocol when set
gquintana Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/logstash/outputs/kafka.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,9 @@ def close
private
def create_producer
begin
# For backward compatibility
security_protocol = "SSL" if ssl and security_protocol.nil?

props = java.util.Properties.new
kafka = org.apache.kafka.clients.producer.ProducerConfig

Expand All @@ -229,7 +232,7 @@ def create_producer

props.put("security.protocol", security_protocol) unless security_protocol.nil?

if security_protocol == "SSL" || ssl
if security_protocol == "SSL"
set_trustore_keystore_config(props)
elsif security_protocol == "SASL_PLAINTEXT"
set_sasl_config(props)
Expand Down