chore: Add gasprice overflow check #3636
Open
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 1ba9157 |
stubbsta
changed the title
Contributor
Author
|
@Ivansete-status This PR is now ready for review, it is one part of resolving #3643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Casting from uint64 to int may cause overflow error.
The register proc in the on_chain groupmanager makes an rpc call to get the gas price (which is uint64), multiplies it by 2 and casts to int to be used in the web3 send method.
Changes
Check for overflow before casting and use max int value if there is an overflow.
relates to #3643