feat: add wallet ffi function for arbitrary public transactions#429
Open
adklempner wants to merge 1 commit intologos-blockchain:mainfrom
Open
feat: add wallet ffi function for arbitrary public transactions#429adklempner wants to merge 1 commit intologos-blockchain:mainfrom
adklempner wants to merge 1 commit intologos-blockchain:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add a generic FFI function for sending arbitrary public transactions to any deployed program, removing the need to add per-program FFI wrappers.
Related: #422
Approach
wallet_ffi_send_public_transactionC FFI function that accepts a program ID, account list, raw instruction bytes, and a signerWalletCore::send_public_transactionasync method that builds, signs, and submits aPublicTransactionInvalidArgumenterror variant for input validation (e.g. instruction length not a multiple of 4)wallet_ffi.h)How to Test
cargo build -p wallet-ffiwallet_ffi_send_public_transactionfrom a logos-core module (see companion PR in logos-execution-zone-module)Dependencies
None.
Future Work
PR Completion Checklist