Open
Conversation
schouhy
approved these changes
Apr 21, 2026
Collaborator
schouhy
left a comment
There was a problem hiding this comment.
LGTM. Left some minor comments
Arjentix
approved these changes
Apr 21, 2026
|
|
||
| // Implement Drop to prevent memory leaks | ||
| impl Drop for IndexerServiceFFI { | ||
| fn drop(&mut self) { |
Collaborator
There was a problem hiding this comment.
Would be nice to apply destructuring pattern here
Collaborator
Author
There was a problem hiding this comment.
Do you want something like:
let IndexerServiceFFI { indexer_handle, runtime } = self;
?
This will create mutable references into fields, which would need to be dereferenced anyway later to produce references into Rust objects. So I do not see the point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
First step of introducing indexer module.
⚙️ Approach
Implemented
indexer_fficrate in a similar way to bedrock node C bindings. For now it starts RPC on its own and this is an intended way of communicating with indexer service.indexer_ffiadded.Also added an item into
deny.toml. There is issues withrandv0.8.5, but it is here transitively for couple of dependencies. It would not even be problematic to fix(just by bumping deps versions), except it is a dependency in a couplelogos-blockchain-*crates. If I bump them, we may break integration or integrations tests, or both.🧪 How to Test
Added integrations tests to tests indexer ffi into
indexer.rs.🔗 Dependencies
None
🔜 Future Work
indexer_ffi. This will be necessary in the future for module completeness.📋 PR Completion Checklist