Conversation
oscarmarino
approved these changes
Oct 30, 2025
Collaborator
oscarmarino
left a comment
oscarmarino
left a comment
There was a problem hiding this comment.
Seems very good, I think we should check the test cases for the metric terms, to be sure that free-stream preservation and similar are still fulfilled, as the changes in those routines are a little difficult to follow without deep insight (it seems only optimization to me, but better to be sure)
Owner
Author
|
Did you have any specific test case in mind? I can try to revive it before the merge. Now the code coverage we have is very bad. |
Owner
Author
|
Also, conflicts should be manually resolved before any kind of test can be run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BSC guys did a great job improving the preprocess (x30 speedup) and more stuff.
They created a pull request to gerasimos_gpu_dev.
I merged their changes into Gerasimos_gpu_dev. Then I moved that branch into here and created this pull request.
This one is not automatic, as main branch here has been modified from Gerasimos_gpu_dev (last modification 5 months ago).
Please take a look when you have a minute. Thanks!