Initial guidance on using type annotations #49
Conversation
|
|
||
| * Do not use `from __future__ import annotations` since it is not compatible with Python 3.6 | ||
| * For importing typing see: http://google.github.io/styleguide/pyguide.html#31912-imports-for-typing | ||
| * Define type annotations as strings so `'int'` instead of `int`. This prevents having issues where types are self referencing |
There was a problem hiding this comment.
I'm not sure it's worth adding all these characters for the small number of classes that reference themselves. Let's just do this on the rare cases it's necessary.
There was a problem hiding this comment.
So http://google.github.io/styleguide/pyguide.html#31912-imports-for-typing states:
Conditionally imported types need to be referenced as strings, to be forward compatible with Python 3.6 where the annotation expressions are actually evaluated.
There was a problem hiding this comment.
I recommend us sticking with strings for now to be consistent
There was a problem hiding this comment.
How about instead we wait until we've dropped support for python 3.6, as this string ugliness isn't required in Python 3.7+ https://www.python.org/dev/peps/pep-0563/
There was a problem hiding this comment.
So type annotations will remain somewhat "ugly" with Python 3.7 and later as well, but we can postpone adopting them once we are able to drop 3.6 support.
joachimmetz
added
the
blocked
No description provided.