Skip to content

Conversation

sshumakov
Copy link
Contributor

@abatishchev
Copy link
Collaborator

abatishchev commented Jun 25, 2025

Hi @sshumakov, thanks for making the change. It's the near the same as #253, but let's use yours to move forward.

@abatishchev abatishchev changed the title Update Microsoft.ServiceFabric.Actors dependency Update Microsoft.ServiceFabric.Actors to 8.0.2707 Jun 25, 2025
@abatishchev
Copy link
Collaborator

Let's see if the check passes. If not, I'll ask @loekd to take a look.

@abatishchev
Copy link
Collaborator

@loekd the CI pipeline fails when runs from a fork, due to the missing permissions, I guess :(

@loekd
Copy link
Owner

loekd commented Jun 26, 2025

Tried something to see if the build will run. I believe there are some breaking changes in the new SF SDK that will need to be implemented here.

@loekd
Copy link
Owner

loekd commented Jun 26, 2025

So, the install of the SF runtime fails with this message. @sshumakov or @abatishchev do you have any connections with the SF team that would understand why?

  $ProgressPreference = 'SilentlyContinue'
  # see https://learn.microsoft.com/en-us/azure/service-fabric/service-fabric-get-started
  Invoke-RestMethod -OutFile setup.exe -Method GET -Uri https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabric.11.0.2707.1.exe
  # .\setup.exe  /accepteula /force /quiet
  Start-Process setup.exe -UseNewEnvironment -ArgumentList '/accepteula /force /quiet' -Wait
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    Solution_Name: ServiceFabric.Mocks.sln
    Test_Project_File: \test\ServiceFabric.Mocks.NetCoreTests\ServiceFabric.Mocks.NetCoreTests.csproj
    Test_Project_Path: \test\ServiceFabric.Mocks.NetCoreTests
    Wap_Project_Path: \src\ServiceFabric.Mocks\ServiceFabric.Mocks.csproj
    DOTNET_ROOT: C:\Program Files\dotnet
6/26/2025 8:02:44 AM,Info,Installing Service Fabric Runtime. Logs written to C:\Windows\TEMP\InstallFabricRuntime_6[3](https://github.com/loekd/ServiceFabric.Mocks/actions/runs/15896200173/job/44828707564#step:5:3)8865217640242955.log
**6/26/2025 8:02:44 AM,Error,Exception type: System.FormatException, Message: Input string was not in a correct format., Stack:    at System.Version.VersionResult.SetFailure(ParseFailureKind failure, String argument)
   at System.Version.TryParseComponent(String component, String componentName, VersionResult& result, Int32& parsedComponent)
   at System.Version.TryParseVersion(String version, VersionResult& result)
   at System.Version.Parse(String input)
   at System.Version..ctor(String version)
   at Microsoft.ServiceFabric.SdkRuntimeCompatibilityCheck.CompatibilityCheckBase.IsVersionAboveOrEqual(String versionLeft, String versionRight)**
   at Microsoft.ServiceFabric.SdkRuntimeCompatibilityCheck.CompatibilityCheckBase.IsVersionCompatible(String sdkVersion, String runtimeVersion, String compatibilityString, String& errorMessage)
   at Microsoft.ServiceFabric.SdkRuntimeCompatibilityCheck.CompatibilityCheckBase.CheckCompatible(String selfJsonString, String selfVersion, String& errorMessage)
   at Microsoft.ServiceFabric.InstallFabricRuntime.Program.Main(String[] args)

@sshumakov
Copy link
Contributor Author

@loekd, it seems to be a known issue #1530, and fix is in progress.

Is there is a way to start build agent, without previous service fabric version installed? This should allow installation.

@loekd
Copy link
Owner

loekd commented Jun 27, 2025

The pipeline runs on windows-latest. Really not much I can do about the pre-installed software there.

Maybe we could create a script that finds out if there's an old version installed and then de-install it? (Wouldn't really know how to find out, and get the proper binaries in place though.)

@sshumakov
Copy link
Contributor Author

@loekd - added script to remove registry folder, to avoid this installation issue. Try running CI build - it should pass now.

@loekd
Copy link
Owner

loekd commented Jun 27, 2025

Nice! Just need to bump the version in the CD build. Then it's OK

@loekd
Copy link
Owner

loekd commented Jun 27, 2025

Thanks so much for your help @sshumakov and @abatishchev!

@loekd loekd merged commit 5cd21bc into loekd:master Jun 27, 2025
4 checks passed
@loekd
Copy link
Owner

loekd commented Jun 27, 2025

At some point I'll create a v8 tag so the version aligns better again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants