introduce LoggingSupport #585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sschulz92 @ybnkv @olsmn What do you think about this aproach? Throwables are logged as warnings |
sschulz92
suggested changes
Nov 2, 2021
Contributor
sschulz92
left a comment
sschulz92
left a comment
There was a problem hiding this comment.
In general this is a good approach I think :)
plugins/org.locationtech.udig.core/src/org/locationtech/udig/core/internal/CorePlugin.java
Outdated
Show resolved
Hide resolved
...ntech.udig.info/src/org/locationtech/udig/tool/info/internal/display/BrowserInfoDisplay.java
Show resolved
Hide resolved
fgdrf
force-pushed
the
F_LOGGING_SUPPORT
branch
from
46ee20f to
579f55f
Compare
Contributor
Author
|
I'm going to add few lines to release-notes and I guess I've to grep through documentations: since ID is not necessary anymore for logging because of usage Plugin.getBundle().getSymbolicName() in LoggingSupport. |
Contributor
Author
|
potential candidats (RST) to update to LoggingSupport:
|
fgdrf
force-pushed
the
F_LOGGING_SUPPORT
branch
3 times, most recently
from
31d803e to
60c7049
Compare
to have a common way to log messages overall modules. Reduces code-duplications as well, if deprecated methods are removed in the future Signed-off-by: Frank Gasdorf <[email protected]>
Change-Id: I0b078706af6cdd32047cf3de2e43724c2e30b167
Change-Id: Id68b57afed3b376a6f18ad2ce20a976a7d27c666 Signed-off-by: Frank Gasdorf <[email protected]>
fgdrf
force-pushed
the
F_LOGGING_SUPPORT
branch
from
60c7049 to
32c70c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to have a common way to log messages overall modules. Reduces
code-duplications as well, if deprecated methods are removed
in the future
Signed-off-by: Frank Gasdorf [email protected]