en.yaml #711

RamzArzFarsi · 2025-12-12T19:14:42Z

Three small mistakes are fixed.

Summary by CodeRabbit

New Features
- Buy flow now proceeds to a post-payment step, requires seller confirmation before sats are sent, and updates the follow-up command.
Bug Fixes
- Adjusted image-processing message wording and normalized newline handling.
Documentation
- Clarified sell guidance to show surplus in sats and made minor wording and label refinements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-12T19:14:53Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)

locales/fa.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated the English localization file (locales/en.yaml) to change buy-flow follow-up from /release to /fiatsent and add a seller-confirmation step; corrected sell guidance to reference sats for surplus; and made minor wording/newline/label adjustments in various messages.

Changes

Cohort / File(s)	Summary
Localization string updates `locales/en.yaml`	Replaced `/release` with `/fiatsent` in buy flow instructions and added a seller-confirmation step; updated sell guidance to indicate sats for the `surplus` parameter; adjusted wording and newline/formatting in image-processing and other messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify the /fiatsent command/handler exists and matches the updated instruction.
Confirm the surplus wording aligns with how amounts are presented/validated elsewhere.

Possibly related PRs

Improve way we show QR invoice to seller #652 — modifies English locale strings for invoice/payment and pending-sell messages and likely overlaps with these localized message changes.

Poem

🐰 I hopped through lines and tweaked a phrase,
Swapped a route and smoothed the maze,
Sats now speak where numbers play,
A seller nod before the pay,
Tiny hops, a brighter day. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'en.yaml' is vague and does not convey meaningful information about the specific changes made to the file.	Use a descriptive title that summarizes the main changes, such as 'Fix buy flow follow-up command and correct sell format descriptions' or 'Update en.yaml with buy flow and sell format corrections'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

locales/en.yaml (1)

428-435: Template variable rename creates breaking change: code still passes id but en.yaml expects orderId.

The code in bot/messages.ts (line 1854) passes id: order._id to render pending_payment_success, but the en.yaml template now expects ${orderId}. This mismatch will cause the order ID to render blank for English users. Synchronize the parameter name in the code to orderId to match the template, or revert the template variable back to ${id}.

Note: Other locale files (it, pt, ru, ko, uk, es, fa, fr, de) still use ${id} in their pending_payment_success templates, so only en.yaml was changed. This inconsistency across locales should also be addressed.

🧹 Nitpick comments (2)

locales/en.yaml (2)
25-25: Clarify /fiatsent usage (with/without order id) to match the bot’s actual command signature.
Right now the instructions say “use the /fiatsent command”, but /help documents /fiatsent <_order id_> while other copy shows /fiatsent without an id (e.g., fiatsent_order_cmd: /fiatsent). If the handler requires an id, this line should say /fiatsent ${orderId} (or explicitly mention selecting the order in-chat).

82-88: Wording is still ambiguous (“add the parameter 0 indicating sats amount”).
Consider tightening to “add 0 as the sats amount” and split the sentence for readability.
-  In order to create a sale with a surplus in the price of 3% $premium$ you need to add the parameter 0 indicating sats amount\. The bot will calculate the selling price using the Bitcoin market price and applying the indicated surplus, you need to add 3 as the last parameter
+  To create a sale with a 3% premium, set the sats amount to 0\. The bot will calculate the sats amount from the market price and apply the premium\. Then add 3 as the last parameter\.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875ede4 and a1fe355.

📒 Files selected for processing (1)

locales/en.yaml (4 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-22T14:03:55.114Z
Learning: Applies to {bot/**,locales/*.json} : Pair new bot flows with corresponding text updates under locales/

📚 Learning: 2025-08-14T18:53:14.640Z

Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-14T18:53:14.640Z
Learning: Follow the Lightning Network hold-invoice escrow flow for buy and sell orders as documented

Applied to files:

locales/en.yaml

locales/en.yaml

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Catrya · 2025-12-12T20:29:17Z

locales/en.yaml

  Proof of payment: ${paymentSecret}
 pending_payment_success: |
-  I have paid the lightning invoice for ${amount} satoshis, order ID: ${id}!
+  I have paid the lightning invoice for ${amount} satoshis, order ID: ${orderId}!


Hi @RamzArzFarsi Thanks for your first contribution!
Was there a specific reason for changing it to ${orderId}?
${id} was used because this template serves dual purposes, it handles both order payments (order._id) and community payments (community.id).
Just want to make sure we maintain compatibility with both use cases.

I noticed the order ID placeholder was ${orderId} in the entire file except for this one particular place. I assumed it must be a typo.

is not a typo

I changed it back.

RamzArzFarsi · 2025-12-13T10:15:36Z

locales/fa.yaml

The old Persian file had weird phrasings and felt like a draft LLM translation.
This is a more refined and natural-sounding translation done manually (no LLM was used).

Catrya · 2025-12-15T22:55:43Z

locales/fa.yaml


-  `/buy 1000 50000 IRT "پرداخت با عابربانک"`
+  `/sell 1000 300000 IRT "کارت به کارت"`


should be /buy, not sell

Catrya

Hi @RamzArzFarsi , it won't compile; there are errors with the location keys. This is what appears when trying to compile:

[2025-12-15T16:52:25.134-06:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:62)

  7 |  ... 
  8 |  ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
  9 |  ... 
 10 |  ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
 11 |  ... 
 12 |  ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

RamzArzFarsi · 2025-12-16T10:13:15Z

Hi @RamzArzFarsi , it won't compile; there are errors with the location keys. This is what appears when trying to compile:

[2025-12-15T16:52:25.134-06:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:62)

  7 |  ... 
  8 |  ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
  9 |  ... 
 10 |  ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
 11 |  ... 
 12 |  ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

The compiling error should be gone now. Please try again and let me know if there are any more errors.

Luquitasjeffrey

Hi @RamzArzFarsi, I pulled your pr on my local and I'm still getting the same error:

[2025-12-17T18:40:51.873-03:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:64)

7 | ...
8 | ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
9 | ...
10 | ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
11 | ...
12 | ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

Please fix your syntax in the fa.yaml file so we can proceed with your pr.
Thanks

Catrya

As @Luquitasjeffrey said, it still doesn't work
The bot compiles but crashes on startup due to YAML syntax errors in fa.yaml. The translation file has invalid formatting that prevents the bot from starting. This needs to be fixed.

Updated Persian translations for disclaimer and instructions.

Corrected pluralization in Persian translations for various terms.

Luquitasjeffrey

Now your pr is Ok. It can be merged to the main branch

RamzArzFarsi · 2025-12-24T23:04:45Z

Please merge the PR if no further action is needed from my side.
And happy holidays to you. 🙂

en.yaml

a1fe355

coderabbitai bot reviewed Dec 12, 2025

View reviewed changes

locales/en.yaml Outdated Show resolved Hide resolved

Update locales/en.yaml

fc4eda7

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Catrya reviewed Dec 12, 2025

View reviewed changes

RamzArzFarsi added 2 commits December 12, 2025 23:31

Update en.yaml

e2bb329

fa.yaml

0bf1e25

RamzArzFarsi commented Dec 13, 2025

View reviewed changes

Catrya reviewed Dec 15, 2025

View reviewed changes

Catrya requested changes Dec 15, 2025

View reviewed changes

RamzArzFarsi added 2 commits December 16, 2025 10:47

Update fa.yaml

36c8b9f

Update fa.yaml

4b4712d

RamzArzFarsi requested a review from Catrya December 16, 2025 10:13

Luquitasjeffrey suggested changes Dec 17, 2025

View reviewed changes

Catrya reviewed Dec 20, 2025

View reviewed changes

RamzArzFarsi added 6 commits December 20, 2025 12:31

FA

6934d9d

FA

fc7a190

FA

0016b63

FA

55e584b

Updated Persian translations for disclaimer and instructions.

FA

7216f1d

FA

c4e92ac

RamzArzFarsi requested review from Catrya and Luquitasjeffrey December 20, 2025 13:42

RamzArzFarsi added 2 commits December 20, 2025 20:36

FA

1c1d4fd

FA

281054b

Corrected pluralization in Persian translations for various terms.

Luquitasjeffrey approved these changes Dec 22, 2025

View reviewed changes


		`/buy 1000 50000 IRT "پرداخت با عابربانک"`
		`/sell 1000 300000 IRT "کارت به کارت"`

en.yaml #711

Are you sure you want to change the base?

en.yaml #711

Uh oh!

Conversation

RamzArzFarsi commented Dec 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Catrya Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi commented Dec 16, 2025

Uh oh!

Luquitasjeffrey left a comment

Choose a reason for hiding this comment

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

Luquitasjeffrey left a comment

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RamzArzFarsi commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2025 •

edited

Loading