fix(bank-account): regenerate federation supergraph for pendingUpdate [ENG-509]#447
Merged
Merged
Conversation
… [ENG-509] #444 added `pendingUpdate` to the public subgraph schema but never regenerated the composed Apollo Router supergraph. The router validates against that baked-in supergraph, so it rejects `bankAccounts { pendingUpdate }` with GRAPHQL_VALIDATION_FAILED (400) even on images built from #444 — which blocks the mobile cashout screen ("No bank account found") on TEST. Ran `make codegen` to recompose the supergraph. Only the generated supergraph.graphql changes (58 insertions, 0 deletions). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #444 (ENG-509) added
pendingUpdateto the public subgraph schema (src/graphql/public/schema.graphql) but the composed Apollo Router supergraph (dev/apollo-federation/supergraph.graphql) was never regenerated.check:sdlonly guards the subgraph SDL, not the supergraph, so the stale supergraph passed CI.api.*.flashapp.meis served by the Apollo Router, which validates queries against that baked-in supergraph. Result: the mobile app'sBankAccountsquery (bankAccounts { ... pendingUpdate { ... } }) is rejected with:even on backend images built from #444. On TEST this surfaces as "No bank account found." on the cashout screen — the 400 drops the whole response, so
bankAccountsreads empty.Fix
Ran
make codegento recompose the supergraph. The subgraph schema was already current, so the only change is the generatedsupergraph.graphql(58 insertions, 0 deletions): thependingUpdate: BankAccountUpdateRequestfield plus theBankAccountUpdateRequesttype/input.Deploy note
This is a chart-baked artifact — merging bumps the flash image/chart; TEST/prod pick it up on the next
make flash ENV=<env>. Verify post-deploy: theflash-supergraphconfigmap and the served__type(name:"BankAccount")both includependingUpdate.🤖 Generated with Claude Code