feat(bank-accounts): update approved bank account — mobile [ENG-509]#665
Merged
islandbitcoin merged 3 commits intoJul 13, 2026
Conversation
Client side of ENG-509. Adds an "Update details" action to ERPNext bank accounts in the Bank accounts hub and a prefilled edit screen that submits a change request for admin review. - EditBankAccount screen (reuses upgrade-flow field components + SupportedBanks); currency shown read-only (locked); confirm sheet stating cashouts continue to current details until approved. - "Update details" entry in the withdraw-row action sheet for ERPNext rows. - Row status pill reflects an open update request (pendingUpdate) instead of a hardcoded "verified". - GraphQL mutation + pendingUpdate query field (regenerated hooks/types). - Navigation route + i18n strings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Part of ENG-509 — this change spans three repos:
Merge order: flash#444 first (it defines the GraphQL contract), then the other two — the mobile change depends on the backend field to work end-to-end. |
…[ENG-509]
- Show the admin's rejection reason as a banner on the edit screen (the
backend now returns rejected requests via pendingUpdate).
- Validate account type against {Chequing, Savings} client-side and guard
the prefill, so a non-canonical stored value can't dead-end at the server.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Clears the translation-drift CI check (every locale must include the keys present in en.json). Adds the 9 new BankAccountsScreen keys as English placeholders — matching the repo's untranslated-key convention — to all 23 translation files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Client side of ENG-509 — lets a user update an approved Jamaican bank account from Settings → Ways to get paid → Bank accounts. (Companion PRs in
flashandfrappe-flash-admin.)Changes
EditBankAccountscreen — reuses the upgrade-flowDropDownField/InputField+SupportedBanks, prefilled from the current account, currency read-only (locked), with a confirm sheet: "Cash-outs keep going to your current account until the new details are approved."WithdrawRowaction sheet for ERPNext (source: "erpnext") rows.use-bank-accountsnow derives the row status pill from the account'spendingUpdate(shows Pending while under review) instead of a hardcoded"verified".bankAccountUpdateRequestmutation +pendingUpdateselection on theBankAccountsquery (regeneratedgenerated.ts/.gqlagainst the localpublic-schema.graphql).Testing
yarn dev:codegen✓ ·yarn tsc:check✓ ·graphql-check(operations valid vs schema) ✓ ·yarn update-translations✓ · eslint ✓.Depends on
The
flashbackend PR (mutation +BankAccount.pendingUpdate) must land for this to function end-to-end.🤖 Generated with Claude Code