Fix: Ensure extendable instance is instance of its own class#17
Merged
Fix: Ensure extendable instance is instance of its own class#17
Conversation
lmignon
force-pushed
the
master-improve-perf
branch
2 times, most recently
from
55765f3 to
9620b30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 89.11% 88.03% -1.08%
==========================================
Files 7 7
Lines 294 301 +7
Branches 68 54 -14
==========================================
+ Hits 262 265 +3
- Misses 20 21 +1
- Partials 12 15 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmignon
force-pushed
the
master-improve-perf
branch
2 times, most recently
from
e0253b1 to
6e88ec2
Compare
lmignon
force-pushed
the
master-improve-perf
branch
from
6e88ec2 to
370f34e
Compare
lmignon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the two instance define the xreg_name attribute we can assert that once is instance of the other or not. Otherwise call super